Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Objects inside Icons #119

Merged
merged 1 commit into from
Dec 14, 2024
Merged

Conversation

BeckerWdf
Copy link
Contributor

Fix Icons according to Eclipse UI guideline.
Left and top pixel row should stay empty according to the guideline.

Also: make the "document" in the "wordwrap" and the "block_selection_mode" icon the same hight as they are shown next to each other in the toolbar.

Contributes: eclipse-platform/eclipse.platform.ui#2582

Fix Icons according to Eclipse UI guideline.
Left and top pixel row should stay empty according to the guideline.

Also: make the "document" in the "wordwrap" and the
"block_selection_mode" icon the same hight as they are shown next to
each other in the toolbar.

Contributes: eclipse-platform/eclipse.platform.ui#2582
@BeckerWdf
Copy link
Contributor Author

image

@BeckerWdf BeckerWdf requested a review from vogella December 13, 2024 15:32
Copy link
Contributor

@vogella vogella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM

@BeckerWdf BeckerWdf merged commit 66daf9f into eclipse-platform:master Dec 14, 2024
4 of 5 checks passed
@BeckerWdf BeckerWdf deleted the word_wrap branch December 14, 2024 13:08
@BeckerWdf BeckerWdf self-assigned this Dec 18, 2024
@BeckerWdf BeckerWdf added this to the 4.35 M1 milestone Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants