Add icons for FindReplaceOverlay #68
Conversation
There was a problem hiding this comment.
@Wittmaxi I think the close_replace and open_replace icons can now be removed as they have been replaced with font icons, can't they?
Once we have an agreement on the folders to place the icons in (see eclipse-platform/eclipse.platform.ui#1192 (comment)), that should also be reflected in this PR.
Wittmaxi
force-pushed
the
MW_FindReplaceOverlayImages
branch
from
17d5eb6 to
3c0b0dd
Compare
HeikoKlare
force-pushed
the
MW_FindReplaceOverlayImages
branch
from
3c0b0dd to
e5a815a
Compare
HeikoKlare
changed the title
There was a problem hiding this comment.
Should be merged along with eclipse-platform/eclipse.platform.ui#1192.
|
Is this one still needed? |
|
@akurtakov I believe so, somehow it was never merged! |
|
@HeikoKlare would you please review/merge this one? |
|
@BeckerWdf As our images guy maybe you can verify everything is good here? |
Wittmaxi
force-pushed
the
MW_FindReplaceOverlayImages
branch
from
e5a815a to
bd41b07
Compare
Add the images used in the editor overlay used to perform find/replace. The images are only added in svg-format whereas they are used in png-format in the Overlay. In particular, a few new images were created and/or adapted from www.iconbolt.com. This PR acommodates eclipse-platform/eclipse.platform.ui#1192
Wittmaxi
force-pushed
the
MW_FindReplaceOverlayImages
branch
from
bd41b07 to
48c2ab5
Compare
|
@BeckerWdf does 48c2ab5 address your comment correctly? |
|
Thank you for checking and merging this, @BeckerWdf! |
Add the images used in the editor overlay used to perform find/replace. The images are only added in svg-format whereas they are used in png-format in the Overlay.
In particular, a few new images were created and/or adapted from www.iconbolt.com.
This PR acommodates
eclipse-platform/eclipse.platform.ui#1192