Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create SVG variants for shared DnD icons #84

Merged
merged 1 commit into from
Jul 20, 2024

Conversation

ptziegler
Copy link
Contributor

@ptziegler ptziegler commented Jul 16, 2024

This creates SVG files for all images that can be accessed via
ISharedImages.IMG_OBJS_DND_*, as well as contributes the 100% and 200%
zoom png files that have been created from them.

In addition to the already existing files, this also contributes a new
variant where the source and mask are merged into a single image.

In order to get the best results when creating the source and mask
images, one should disable anti-aliasing.

This creates SVG files for all images that can be accessed via
ISharedImages.IMG_OBJS_DND_*, as well as contributes the 100% and 200%
zoom png files that have been created from them.

In addition to the already existing files, this also contributes a new
variant where the source and mask are merged into a single image.

In order to get the best results when creating the source and mask
images, one should disable anti-aliasing.
@ptziegler
Copy link
Contributor Author

ptziegler commented Jul 19, 2024

A side-by-side comparison of all icons: The first three rows are the images produced from the current bmp files. The next six lines are the png files without anti-aliasing (both in 96 and 192DPI). The last two lines are the png files with anti-aliasing and both source and mask merged into a single image (also both 96 and 192DPI).

image

@HeikoKlare
Copy link
Contributor

Belongs to eclipse-platform/eclipse.platform.ui#2084
Merging this as the using PR in platform.ui has been merged.

Thank you, @ptziegler!

@HeikoKlare HeikoKlare merged commit d925183 into eclipse-platform:master Jul 20, 2024
3 checks passed
@ptziegler ptziegler deleted the 2x-dnd branch July 20, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants