[I-Build] Unify test job names to schema os-arch-javaVersion #2481
+40
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and further simplify variable interpolation. This simplifies later additions of new os-arch combinations.
HannesWell
commented
Oct 26, 2024
Comment on lines
+185
to
+193
| <resources id="testsConfigExpected"> | ||
| <string>ep${eclipseStreamMajor}${eclipseStreamMinor}${buildType}-unit-mac64-java17_macosx.cocoa.x86_64_17</string> | ||
| <string>ep${eclipseStreamMajor}${eclipseStreamMinor}${buildType}-unit-macM1-java17_macosx.cocoa.aarch64_17</string> | ||
| <string>ep${eclipseStreamMajor}${eclipseStreamMinor}${buildType}-unit-win32-java17_win32.win32.x86_64_17</string> | ||
| <string>ep${eclipseStreamMajor}${eclipseStreamMinor}${buildType}-unit-cen64-gtk3-java17_linux.gtk.x86_64_17</string> | ||
| <string>ep${eclipseStreamMajor}${eclipseStreamMinor}${buildType}-unit-cen64-gtk3-java21_linux.gtk.x86_64_21</string> | ||
| <string>ep${eclipseStreamMajor}${eclipseStreamMinor}${buildType}-unit-cen64-gtk3-java24_linux.gtk.x86_64_24</string> | ||
| </resources> | ||
| <pathconvert property="testsConfigExpected" refid="testsConfigExpected" pathsep="," /> |
There was a problem hiding this comment.
The resulting value is not changed. Just the definition is made more readable, similar for the I-build publication.
And I also verify that this strategy works.
|
There is only one way to verify it - push the pr, start new I-build, verify everything is published. This is literally one of the most overcomplicated parts of the process so every simplification is more than welcome. |
|
Ok, yes. Will do it as soon as I have a bit of time to handle possible errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and further simplify variable interpolation.
This simplifies later additions of new os-arch combinations.
I expect that this will change the labels and URLs of test reports accordingly, for example in
https://download.eclipse.org/eclipse/downloads/drops4/I20241025-1840/
But I assume that's not a problem, is it?
@akurtakov or @iloveeclipse or anybody else do you have any objections or do you anything that could be missing?
I tested locally that the changes in how to apply the variables in the job configs leads to the desired results, so from my side this is ready.