Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PoC] Edge: Mouse events on DOM -> SWT mouse events #1545

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sratz
Copy link
Member

@sratz sratz commented Oct 18, 2024

Would resolve #1540.

}
@Override
public Object function (Object[] arguments) {
System.out.println(Arrays.toString(arguments));
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I receive the mouse events just fine, e.g. in the "internal web browser".

But for some reason I do not receive any events in the element info popup or the variable hover.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mouse events only seem to be processed when then content is retrieved from an "ordinary" URL. Whenever you set contents via setText (such as in the Javadoc view, in the Java element info popup, in the help) it does not work. It does not depend on how the widget is embedded: in the help view, the first page is custom content (also with a custom context menu), which does not report mouse events, while when navigating to other entries in the help (like from the "see also" list), mouse events will be reported.

So it seems to be some problem of registering the browser function for "custom content" pages. Is it even possible to register browser functions to them?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what I thought as well at first, but it works perfectly fine with other setText()-based browser usages, so does the following example:

public class Test {

	public static void main(String[] args) {
		Display display = Display.getDefault();
		Shell shell = new Shell ();
		shell.setLayout(new FillLayout());

		new Browser(shell, SWT.EDGE).setText("hi");

		shell.open ();
		while (!shell.isDisposed()) {
			if (!display.readAndDispatch ()) display.sleep ();
		}
		display.dispose ();
	}
}

I don't understand what the element info / hover does differently.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, easy one... It's simply that those use Browser.setJavascriptEnabled(false)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://learn.microsoft.com/en-us/microsoft-edge/webview2/reference/win32/iwebview2settings#get_isscriptenabled:

This only affects scripts in the document; scripts injected with ExecuteScript will run even if script is disabled. It is true by default.

So we need to register those listeners on the window, not the document.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, no dice. Doesn't make a difference... I guess this script-based approach won't be possible universally :(

Copy link
Contributor

Test Results

   486 files  ±0     486 suites  ±0   7m 34s ⏱️ +5s
 4 154 tests ±0   4 146 ✅ ±0   8 💤 ±0  0 ❌ ±0 
16 370 runs  ±0  16 278 ✅ ±0  92 💤 ±0  0 ❌ ±0 

Results for commit 3ab1c32. ± Comparison against base commit 2b675ad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edge Browser: Replace BrowserInformationControl dosn't work on hover
2 participants