Add constant for riscv64 architecture in Platform class #1575
+10
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HannesWell
commented
Oct 2, 2024
| @@ -409,6 +409,15 @@ public static boolean isMac() { | |||
| */ | |||
| public static final String ARCH_AARCH64 = "aarch64";//$NON-NLS-1$ | |||
|
|
|||
| /** | |||
| * Constant string (value {@code aarch64} indicating the platform is running on | |||
There was a problem hiding this comment.
The value of course should have been riscv64. This is fixed in
Open
33 tasks
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @merks pointed out, we should add a
riscv64constant in the Platform class, that that this architecture is now supported on Linux.Part of eclipse-platform/eclipse.platform.releng.aggregator#2310
@yuzibo FYI