-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable all breakpoints bugfix #1584
Merged
jukzi
merged 2 commits into
eclipse-platform:master
from
SougandhS:DisableAllBreakpoints_MinorBugFix
Oct 11, 2024
Merged
Disable all breakpoints bugfix #1584
jukzi
merged 2 commits into
eclipse-platform:master
from
SougandhS:DisableAllBreakpoints_MinorBugFix
Oct 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @jukzi |
jukzi
reviewed
Oct 11, 2024
...bug.ui/ui/org/eclipse/debug/internal/ui/actions/breakpoints/DisableAllBreakpointsAction.java
Show resolved
Hide resolved
jukzi
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, could be improved but it is also fine as is
jukzi
reviewed
Oct 11, 2024
...bug.ui/ui/org/eclipse/debug/internal/ui/actions/breakpoints/DisableAllBreakpointsAction.java
Outdated
Show resolved
Hide resolved
jukzi
reviewed
Oct 11, 2024
...bug.ui/ui/org/eclipse/debug/internal/ui/actions/breakpoints/DisableAllBreakpointsAction.java
Outdated
Show resolved
Hide resolved
SougandhS
force-pushed
the
DisableAllBreakpoints_MinorBugFix
branch
from
October 11, 2024 10:02
3863bee
to
16d8571
Compare
Thanks. |
Thanks for the analysis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1583