-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3950] Activate multiple selection on the Selection Dialog #3957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florianbarbin
force-pushed
the
fba/enh/multipleSelectionDialog
branch
from
September 3, 2024 15:25
e07331f
to
a67fcc4
Compare
florianbarbin
added
priority: low
and removed
pr: to review soon
package: selection
labels
Sep 3, 2024
florianbarbin
force-pushed
the
fba/enh/multipleSelectionDialog
branch
from
September 3, 2024 15:39
a67fcc4
to
2dd3526
Compare
florianbarbin
force-pushed
the
fba/enh/edgeToolSelectionDialog
branch
from
September 5, 2024 13:09
fc4f6d6
to
2d00ebd
Compare
florianbarbin
force-pushed
the
fba/enh/multipleSelectionDialog
branch
from
September 5, 2024 13:11
2dd3526
to
fef399d
Compare
florianbarbin
force-pushed
the
fba/enh/edgeToolSelectionDialog
branch
from
September 5, 2024 15:28
2d00ebd
to
a62107f
Compare
florianbarbin
force-pushed
the
fba/enh/multipleSelectionDialog
branch
from
September 5, 2024 15:29
fef399d
to
8abd0c1
Compare
florianbarbin
force-pushed
the
fba/enh/edgeToolSelectionDialog
branch
from
September 6, 2024 09:55
a62107f
to
2dfb2b4
Compare
florianbarbin
force-pushed
the
fba/enh/multipleSelectionDialog
branch
from
September 6, 2024 09:58
8abd0c1
to
8794fed
Compare
florianbarbin
force-pushed
the
fba/enh/edgeToolSelectionDialog
branch
2 times, most recently
from
September 11, 2024 13:35
9fa1599
to
912d593
Compare
florianbarbin
force-pushed
the
fba/enh/multipleSelectionDialog
branch
2 times, most recently
from
September 11, 2024 13:38
1c08416
to
2a5c4a1
Compare
florianbarbin
force-pushed
the
fba/enh/edgeToolSelectionDialog
branch
from
September 12, 2024 08:05
912d593
to
42fa16a
Compare
florianbarbin
force-pushed
the
fba/enh/multipleSelectionDialog
branch
from
September 12, 2024 08:06
2a5c4a1
to
4142f61
Compare
florianbarbin
force-pushed
the
fba/enh/edgeToolSelectionDialog
branch
from
September 12, 2024 15:45
42fa16a
to
c996ead
Compare
florianbarbin
force-pushed
the
fba/enh/multipleSelectionDialog
branch
from
September 12, 2024 15:49
4142f61
to
ddaf090
Compare
florianbarbin
force-pushed
the
fba/enh/edgeToolSelectionDialog
branch
from
September 12, 2024 21:12
c996ead
to
601cfc5
Compare
florianbarbin
force-pushed
the
fba/enh/multipleSelectionDialog
branch
from
September 12, 2024 21:12
ddaf090
to
1202d22
Compare
florianbarbin
force-pushed
the
fba/enh/multipleSelectionDialog
branch
2 times, most recently
from
September 23, 2024 15:40
109aa48
to
1747903
Compare
florianbarbin
force-pushed
the
fba/enh/edgeToolSelectionDialog
branch
6 times, most recently
from
September 24, 2024 09:27
a6a6e69
to
6b5f421
Compare
florianbarbin
force-pushed
the
fba/enh/multipleSelectionDialog
branch
from
September 24, 2024 09:29
1747903
to
c335c74
Compare
florianbarbin
force-pushed
the
fba/enh/edgeToolSelectionDialog
branch
from
September 26, 2024 08:35
6b5f421
to
4e3c06b
Compare
florianbarbin
force-pushed
the
fba/enh/multipleSelectionDialog
branch
2 times, most recently
from
September 26, 2024 09:52
5657ae2
to
de2304f
Compare
florianbarbin
force-pushed
the
fba/enh/edgeToolSelectionDialog
branch
from
September 27, 2024 13:55
4e3c06b
to
ea72ec4
Compare
florianbarbin
force-pushed
the
fba/enh/multipleSelectionDialog
branch
from
September 27, 2024 13:55
de2304f
to
1c1a4b7
Compare
florianbarbin
force-pushed
the
fba/enh/edgeToolSelectionDialog
branch
from
October 1, 2024 15:31
ea72ec4
to
139fb44
Compare
florianbarbin
force-pushed
the
fba/enh/multipleSelectionDialog
branch
from
October 1, 2024 15:32
1c1a4b7
to
4c5f1c6
Compare
florianbarbin
force-pushed
the
fba/enh/edgeToolSelectionDialog
branch
from
October 2, 2024 14:55
139fb44
to
e2a64bb
Compare
florianbarbin
force-pushed
the
fba/enh/multipleSelectionDialog
branch
from
October 2, 2024 14:55
4c5f1c6
to
5b7f111
Compare
florianbarbin
force-pushed
the
fba/enh/edgeToolSelectionDialog
branch
from
October 4, 2024 12:45
e2a64bb
to
7f617bf
Compare
florianbarbin
force-pushed
the
fba/enh/multipleSelectionDialog
branch
from
October 4, 2024 12:45
5b7f111
to
2c661c3
Compare
florianbarbin
force-pushed
the
fba/enh/edgeToolSelectionDialog
branch
from
October 8, 2024 12:29
7f617bf
to
f2be467
Compare
florianbarbin
force-pushed
the
fba/enh/multipleSelectionDialog
branch
from
October 8, 2024 12:29
2c661c3
to
125ce89
Compare
sbegaudeau
force-pushed
the
fba/enh/edgeToolSelectionDialog
branch
from
October 11, 2024 14:19
f2be467
to
b7bd892
Compare
This commit allows the specifier to indicate if the selection dialog should allow multiple selection. Bug: #3950 Signed-off-by: Florian Barbin <florian.barbin@obeo.fr>
sbegaudeau
force-pushed
the
fba/enh/multipleSelectionDialog
branch
from
October 11, 2024 14:44
125ce89
to
836448e
Compare
…tiple types Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
sbegaudeau
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've finally been able to provide the behavior that I was expected in Papaya so it seems to work as expected. I'll wait for the build and I'll merge it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows the specifier to indicate if the selection dialog should allow multiple selection.
Bug: #3950
Pull request template
General purpose
What is the main goal of this pull request?
Project management
priority:
andpr:
labels been added to the pull request? (In case of doubt, start with the labelspriority: low
andpr: to review later
)area:
,difficulty:
,type:
)CHANGELOG.adoc
been updated to reference the relevant issues?CHANGELOG.adoc
? (Including changes in the GraphQL API)CHANGELOG.adoc
? For example indoc/screenshots/2022.5.0-my-new-feature.png
Architectural decision records (ADR)
[doc]
?CHANGELOG.adoc
?Dependencies
CHANGELOG.adoc
?CHANGELOG.adoc
?Frontend
This section is not relevant if your contribution does not come with changes to the frontend.
General purpose
Typing
We need to improve the typing of our code, as such, we require every contribution to come with proper TypeScript typing for both changes contributing new files and those modifying existing files.
Please ensure that the following statements are true for each file created or modified (this may require you to improve code outside of your contribution).
useMutation<DATA_TYPE, VARIABLE_TYPE>(…)
useQuery<DATA_TYPE, VARIABLE_TYPE>(…)
useSubscription<DATA_TYPE, VARIABLE_TYPE>(…)
useMachine<CONTEXT_TYPE, EVENTS_TYPE>(…)
useState<STATE_TYPE>(…)
?.
(if the GraphQL API specifies that a field cannot benull
, do not treat it has potentiallynull
for example)let diagram: Diagram | null = null;
)Backend
This section is not relevant if your contribution does not come with changes to the backend.
General purpose
Architecture
Review
How to test this PR?
Please describe here the various use cases to test this pull request