Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3950] Activate multiple selection on the Selection Dialog #3957

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

florianbarbin
Copy link
Contributor

This commit allows the specifier to indicate if the selection dialog should allow multiple selection.

Bug: #3950

Pull request template

General purpose

What is the main goal of this pull request?

  • Bug fixes
  • New features
  • Documentation
  • Cleanup
  • Tests
  • Build / releng

Project management

  • Has the pull request been added to the relevant project and milestone? (Only if you know that your work is part of a specific iteration such as the current one)
  • Have the priority: and pr: labels been added to the pull request? (In case of doubt, start with the labels priority: low and pr: to review later)
  • Have the relevant issues been added to the pull request?
  • Have the relevant labels been added to the issues? (area:, difficulty:, type:)
  • Have the relevant issues been added to the same project and milestone as the pull request?
  • Has the CHANGELOG.adoc been updated to reference the relevant issues?
  • Have the relevant API breaks been described in the CHANGELOG.adoc? (Including changes in the GraphQL API)
  • In case of a change with a visual impact, are there any screenshots in the CHANGELOG.adoc? For example in doc/screenshots/2022.5.0-my-new-feature.png

Architectural decision records (ADR)

  • Does the title of the commit contributing the ADR start with [doc]?
  • Are the ADRs mentioned in the relevant section of the CHANGELOG.adoc?

Dependencies

  • Are the new / upgraded dependencies mentioned in the relevant section of the CHANGELOG.adoc?
  • Are the new dependencies justified in the CHANGELOG.adoc?

Frontend

This section is not relevant if your contribution does not come with changes to the frontend.

General purpose

  • Is the code properly tested? (Plain old JavaScript tests for business code and tests based on React Testing Library for the components)

Typing

We need to improve the typing of our code, as such, we require every contribution to come with proper TypeScript typing for both changes contributing new files and those modifying existing files.
Please ensure that the following statements are true for each file created or modified (this may require you to improve code outside of your contribution).

  • Variables have a proper type
  • Functions’ arguments have a proper type
  • Functions’ return type are specified
  • Hooks are properly typed:
    • useMutation<DATA_TYPE, VARIABLE_TYPE>(…)
    • useQuery<DATA_TYPE, VARIABLE_TYPE>(…)
    • useSubscription<DATA_TYPE, VARIABLE_TYPE>(…)
    • useMachine<CONTEXT_TYPE, EVENTS_TYPE>(…)
    • useState<STATE_TYPE>(…)
  • All components have a proper typing for their props
  • No useless optional chaining with ?. (if the GraphQL API specifies that a field cannot be null, do not treat it has potentially null for example)
  • Nullable values have a proper type (for example let diagram: Diagram | null = null;)

Backend

This section is not relevant if your contribution does not come with changes to the backend.

General purpose

  • Are all the event handlers tested?
  • Are the event processor tested?
  • Is the business code (services) tested?
  • Are diagram layout changes tested?

Architecture

  • Are data structure classes properly separated from behavioral classes?
  • Are all the relevant fields final?
  • Is any data structure mutable? If so, please write a comment indicating why
  • Are behavioral classes either stateless or side effect free?

Review

How to test this PR?

Please describe here the various use cases to test this pull request

  • Has the Kiwi TCMS test suite been updated with tests for this contribution?

@florianbarbin florianbarbin added this to the 2024.9.0 milestone Sep 3, 2024
@florianbarbin florianbarbin force-pushed the fba/enh/edgeToolSelectionDialog branch 2 times, most recently from 9fa1599 to 912d593 Compare September 11, 2024 13:35
@florianbarbin florianbarbin force-pushed the fba/enh/multipleSelectionDialog branch 2 times, most recently from 1c08416 to 2a5c4a1 Compare September 11, 2024 13:38
@AxelRICHARD AxelRICHARD removed this from the 2024.9.0 milestone Sep 16, 2024
@florianbarbin florianbarbin force-pushed the fba/enh/multipleSelectionDialog branch 2 times, most recently from 109aa48 to 1747903 Compare September 23, 2024 15:40
@florianbarbin florianbarbin force-pushed the fba/enh/edgeToolSelectionDialog branch 6 times, most recently from a6a6e69 to 6b5f421 Compare September 24, 2024 09:27
@florianbarbin florianbarbin force-pushed the fba/enh/multipleSelectionDialog branch 2 times, most recently from 5657ae2 to de2304f Compare September 26, 2024 09:52
@florianbarbin florianbarbin force-pushed the fba/enh/edgeToolSelectionDialog branch from ea72ec4 to 139fb44 Compare October 1, 2024 15:31
@florianbarbin florianbarbin force-pushed the fba/enh/multipleSelectionDialog branch from 1c1a4b7 to 4c5f1c6 Compare October 1, 2024 15:32
@florianbarbin florianbarbin force-pushed the fba/enh/edgeToolSelectionDialog branch from 139fb44 to e2a64bb Compare October 2, 2024 14:55
@florianbarbin florianbarbin force-pushed the fba/enh/multipleSelectionDialog branch from 4c5f1c6 to 5b7f111 Compare October 2, 2024 14:55
@florianbarbin florianbarbin force-pushed the fba/enh/edgeToolSelectionDialog branch from e2a64bb to 7f617bf Compare October 4, 2024 12:45
@florianbarbin florianbarbin force-pushed the fba/enh/multipleSelectionDialog branch from 5b7f111 to 2c661c3 Compare October 4, 2024 12:45
@florianbarbin florianbarbin force-pushed the fba/enh/edgeToolSelectionDialog branch from 7f617bf to f2be467 Compare October 8, 2024 12:29
@florianbarbin florianbarbin force-pushed the fba/enh/multipleSelectionDialog branch from 2c661c3 to 125ce89 Compare October 8, 2024 12:29
@sbegaudeau sbegaudeau force-pushed the fba/enh/edgeToolSelectionDialog branch from f2be467 to b7bd892 Compare October 11, 2024 14:19
Base automatically changed from fba/enh/edgeToolSelectionDialog to master October 11, 2024 14:40
This commit allows the specifier to indicate if the selection dialog
should allow multiple selection.

Bug: #3950
Signed-off-by: Florian Barbin <florian.barbin@obeo.fr>
@sbegaudeau sbegaudeau force-pushed the fba/enh/multipleSelectionDialog branch from 125ce89 to 836448e Compare October 11, 2024 14:44
…tiple types

Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
Copy link
Member

@sbegaudeau sbegaudeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've finally been able to provide the behavior that I was expected in Papaya so it seems to work as expected. I'll wait for the build and I'll merge it.

@sbegaudeau sbegaudeau merged commit 5785ec8 into master Oct 11, 2024
4 checks passed
@sbegaudeau sbegaudeau deleted the fba/enh/multipleSelectionDialog branch October 11, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Have the multiple selection on the Selection Dialog
3 participants