From fd6ea4378d284e6deb2f6f3184204fc668ea88e1 Mon Sep 17 00:00:00 2001
From: Nitin Vavdiya <nitin.vavdiya@smartsensesolutions.com>
Date: Tue, 2 Apr 2024 18:34:08 +0530
Subject: [PATCH] code changes as per review

---
 .../java/org/eclipse/tractusx/ssi/examples/VC.java |  3 ---
 .../tractusx/ssi/lib/jwt/SignedJwtVerifier.java    |  1 -
 .../eclipse/tractusx/ssi/lib/proof/IVerifier.java  | 14 +++++---------
 3 files changed, 5 insertions(+), 13 deletions(-)

diff --git a/src/main/java/org/eclipse/tractusx/ssi/examples/VC.java b/src/main/java/org/eclipse/tractusx/ssi/examples/VC.java
index b8b65899..deda73e5 100644
--- a/src/main/java/org/eclipse/tractusx/ssi/examples/VC.java
+++ b/src/main/java/org/eclipse/tractusx/ssi/examples/VC.java
@@ -54,15 +54,12 @@ private VC() {
    */
   public static VerifiableCredential createVCWithoutProof() {
 
-    // VC Builder
     final VerifiableCredentialBuilder verifiableCredentialBuilder =
         new VerifiableCredentialBuilder();
 
-    // VC Subject
     final VerifiableCredentialSubject verifiableCredentialSubject =
         new VerifiableCredentialSubject(Map.of("test", "test"));
 
-    // Using Builder
     return verifiableCredentialBuilder
         .id(URI.create("did:test:id"))
         .type(List.of(VerifiableCredentialType.VERIFIABLE_CREDENTIAL))
diff --git a/src/main/java/org/eclipse/tractusx/ssi/lib/jwt/SignedJwtVerifier.java b/src/main/java/org/eclipse/tractusx/ssi/lib/jwt/SignedJwtVerifier.java
index 55e05987..bcfa184c 100644
--- a/src/main/java/org/eclipse/tractusx/ssi/lib/jwt/SignedJwtVerifier.java
+++ b/src/main/java/org/eclipse/tractusx/ssi/lib/jwt/SignedJwtVerifier.java
@@ -63,7 +63,6 @@ public class SignedJwtVerifier {
    * @throws DidParseException the did parse error
    * @throws DidResolverException the did resolve error
    * @throws SignatureVerificationException the signature verification error
-   * @throws UnsupportedVerificationMethodException the unsupported verification error
    * @throws SignatureParseException the signature parse error
    */
   public boolean verify(SignedJWT jwt)
diff --git a/src/main/java/org/eclipse/tractusx/ssi/lib/proof/IVerifier.java b/src/main/java/org/eclipse/tractusx/ssi/lib/proof/IVerifier.java
index 8a8d14a4..f429730c 100644
--- a/src/main/java/org/eclipse/tractusx/ssi/lib/proof/IVerifier.java
+++ b/src/main/java/org/eclipse/tractusx/ssi/lib/proof/IVerifier.java
@@ -23,10 +23,8 @@
 
 import org.eclipse.tractusx.ssi.lib.exception.did.DidParseException;
 import org.eclipse.tractusx.ssi.lib.exception.key.InvalidPublicKeyFormatException;
-import org.eclipse.tractusx.ssi.lib.exception.proof.NoVerificationKeyFoundException;
 import org.eclipse.tractusx.ssi.lib.exception.proof.SignatureParseException;
 import org.eclipse.tractusx.ssi.lib.exception.proof.SignatureVerificationException;
-import org.eclipse.tractusx.ssi.lib.exception.proof.UnsupportedSignatureTypeException;
 import org.eclipse.tractusx.ssi.lib.model.verifiable.Verifiable;
 import org.eclipse.tractusx.ssi.lib.model.verifiable.credential.VerifiableCredential;
 import org.eclipse.tractusx.ssi.lib.proof.hash.HashedLinkedData;
@@ -40,14 +38,12 @@ public interface IVerifier {
    * @param hashedLinkedData the hashed linked data
    * @param verifiable {@link VerifiableCredential} the verifiable
    * @return boolean if verified or not
-   * @throws UnsupportedSignatureTypeException
-   * @throws SignatureParseException
-   * @throws InvalidPublicKeyFormatException
-   * @throws SignatureVerificationException
-   * @throws DidParseException
-   * @throws NoVerificationKeyFoundException
+   * @throws SignatureParseException the signature parse error
+   * @throws InvalidPublicKeyFormatException the invalid public key error
+   * @throws SignatureVerificationException the signature verification error
+   * @throws DidParseException the did parse error
    */
-  public boolean verify(HashedLinkedData hashedLinkedData, Verifiable verifiable)
+  boolean verify(HashedLinkedData hashedLinkedData, Verifiable verifiable)
       throws SignatureParseException, DidParseException, InvalidPublicKeyFormatException,
           SignatureVerificationException;
 }