fix: add validation to verification method and Issuer in VC #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DominikPinsel
approved these changes
Nov 22, 2023
|
@borisrizov-zf Can we merge this? :) |
borisrizov-zf
approved these changes
Nov 23, 2023
src/main/java/org/eclipse/tractusx/ssi/lib/proof/LinkedDataProofValidation.java
Outdated
Show resolved
Hide resolved
src/main/java/org/eclipse/tractusx/ssi/lib/proof/LinkedDataProofValidation.java
Show resolved
Hide resolved
|
@DominikPinsel gotta push out the Maven Central release first, otherwise we'll get a version mismatch between tractus-x 0.0.17 and the catenax-ng 0.0.17 |
borisrizov-zf
approved these changes
Nov 30, 2023
|
@mustafasalfiti please rebase and we can merge. |
|
@mustafasalfiti I forgot, please add an entry in the |
mustafasalfiti
force-pushed
the
fix/verificationMethod-validation
branch
from
3673fb1
to
935143d
Compare
borisrizov-zf
requested changes
Nov 30, 2023
|
You'll have to run |
borisrizov-zf
approved these changes
Dec 1, 2023
mustafasalfiti
force-pushed
the
fix/verificationMethod-validation
branch
2 times, most recently
from
b6cc373
to
ce1cdcb
Compare
mustafasalfiti
force-pushed
the
fix/verificationMethod-validation
branch
from
ce1cdcb
to
ffdb0e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we had a problem that a VC proof will be valid even if the first part of the verificationMethod inside the proof is not equal to the Issuer did and that should not be the case
in this PR we have added an extra layer of validation to check if the first part of the verificationMethod equal to the issuer of the VC
as well there is an extra test to check the correction of the code.