-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: adding Proof Configuration to Signature #77
Feat: adding Proof Configuration to Signature #77
Conversation
@DominikPinsel @matgnt @borisrizov-zf @bjoern-arnold, please for your review. |
I would leave this to the others to review. I'm not a Java developer and don't know the libraries internal structure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea with the new ProofSignature objects :)
57b7e59
to
8c676be
Compare
@borisrizov-zf Rebase is done, you can merge it 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please re-check your PR, the copyright year seems to be wrong on multiple files. Also method documentation has been removed, but it is essential to have documentation to be Maven Central compliant.
I'll re-do the review after these issues have been fixed.
src/main/java/org/eclipse/tractusx/ssi/examples/Verification.java
Outdated
Show resolved
Hide resolved
src/main/java/org/eclipse/tractusx/ssi/lib/exception/did/DidParseException.java
Outdated
Show resolved
Hide resolved
src/main/java/org/eclipse/tractusx/ssi/lib/exception/json/TransformJsonLdException.java
Outdated
Show resolved
Hide resolved
src/main/java/org/eclipse/tractusx/ssi/lib/exception/key/InvalidPrivateKeyFormatException.java
Outdated
Show resolved
Hide resolved
@koptan Hi, still many more files have the docs deleted, and the copyright year is not 2024. I haven't marked them explicitly, due to the sheer quantity of files. Please review them and fix these issues, before I can continue. |
6198c2a
to
f9af565
Compare
src/main/java/org/eclipse/tractusx/ssi/lib/exception/resolver/DidWebException.java
Show resolved
Hide resolved
src/main/java/org/eclipse/tractusx/ssi/lib/proof/transform/LinkedDataTransformer.java
Outdated
Show resolved
Hide resolved
src/main/java/org/eclipse/tractusx/ssi/lib/proof/types/jws/JWSProofVerifier.java
Outdated
Show resolved
Hide resolved
src/test/java/org/eclipse/tractusx/ssi/lib/proof/LinkedDataProofValidationComponentTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/eclipse/tractusx/ssi/lib/util/identity/TestIdentityFactory.java
Show resolved
Hide resolved
@koptan can you point me in the right direction about the following: verification method can be either a multibase string or a map, but I cannot see where transformation is taking place. The interface which binds these seems to be missing the option to easily extend to something like |
@borisrizov-zf transformation is happening in TransformedLinkedData, we accept any JsonLD object as parameter. |
src/main/java/org/eclipse/tractusx/ssi/lib/did/web/util/DidWebParser.java
Outdated
Show resolved
Hide resolved
src/main/java/org/eclipse/tractusx/ssi/lib/jwt/SignedJwtFactory.java
Outdated
Show resolved
Hide resolved
@koptan Hi, the branch needs rebasing, you're out of sync with main. |
BREAKING CHANGE: a lot of Exception has been added and removed
66dc967
to
5943b95
Compare
Description
PR to include the proof configuration in the final hash during the process of creating and verifying the proof.
Therefore, the verification process should fail if any values in the Proof Configuration attributes change.
This PR should fix #34, also it's merge #38
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: