-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: missing credential status in builder #90
fix: missing credential status in builder #90
Conversation
@borisrizov-zf |
@@ -178,6 +179,9 @@ public VerifiableCredential build() { | |||
if (expirationDate != null) { | |||
map.put(VerifiableCredential.EXPIRATION_DATE, formatter.format(expirationDate)); | |||
} | |||
if (!Objects.isNull(credentialStatus)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The intended scope of Objects.isNull
is in a lambda expression. This can be replaced with credentialStatus == null
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed.
rebase done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. This can be merged, I'll check if it conflicts with #77 and if not we can do it first.
@nitin-vavdiya No conflicts, so you can rebase and I'll merge after that. |
Rebase done |
@nitin-vavdiya Your rebase is not using upstream/main. Follow these steps: git config --global rerere.enable true
git fetch upstream
git checkout fix/vc-builder-credential-status-issue
git rebase upstream/main
# fix the conflict, rerere will auto-fix it for every commit after that |
done |
44be1d5
to
4ae905d
Compare
Description
Fix for: #70
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: