From 71c69537ef42e614d5fcf19f937381da717d0d5a Mon Sep 17 00:00:00 2001 From: "Krzysztof Massalski (Extern)" Date: Thu, 24 Aug 2023 16:22:31 +0200 Subject: [PATCH 1/2] feat(impl):[TRI-1570] filter our bpns --- .../tractusx/irs/aaswrapper/job/ItemTreesAssembler.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/irs-api/src/main/java/org/eclipse/tractusx/irs/aaswrapper/job/ItemTreesAssembler.java b/irs-api/src/main/java/org/eclipse/tractusx/irs/aaswrapper/job/ItemTreesAssembler.java index a3b72c93c7..e3ed3107c9 100644 --- a/irs-api/src/main/java/org/eclipse/tractusx/irs/aaswrapper/job/ItemTreesAssembler.java +++ b/irs-api/src/main/java/org/eclipse/tractusx/irs/aaswrapper/job/ItemTreesAssembler.java @@ -31,6 +31,7 @@ import lombok.RequiredArgsConstructor; import lombok.extern.slf4j.Slf4j; +import org.apache.commons.lang3.StringUtils; import org.eclipse.tractusx.irs.component.Bpn; import org.eclipse.tractusx.irs.component.Relationship; import org.eclipse.tractusx.irs.component.Submodel; @@ -64,7 +65,7 @@ public class ItemTreesAssembler { tombstones.addAll(itemGraph.getTombstones()); shells.addAll(itemGraph.getShells()); submodels.addAll(itemGraph.getSubmodels()); - bpns.addAll(itemGraph.getBpns()); + bpns.addAll(itemGraph.getBpns().stream().filter(bpn -> StringUtils.isNotBlank(bpn.getManufacturerName())).toList()); }); log.info("Assembled item graph from {} partial graphs", numberOfPartialTrees); From 37c93b66321acc98734909f9c4d2a29fb9126ed9 Mon Sep 17 00:00:00 2001 From: "Krzysztof Massalski (Extern)" Date: Fri, 25 Aug 2023 08:55:34 +0200 Subject: [PATCH 2/2] feat(impl):[TRI-1570] update test --- .../test/java/org/eclipse/tractusx/irs/IrsFunctionalTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/irs-api/src/test/java/org/eclipse/tractusx/irs/IrsFunctionalTest.java b/irs-api/src/test/java/org/eclipse/tractusx/irs/IrsFunctionalTest.java index 3c81db74c0..0f14d346da 100644 --- a/irs-api/src/test/java/org/eclipse/tractusx/irs/IrsFunctionalTest.java +++ b/irs-api/src/test/java/org/eclipse/tractusx/irs/IrsFunctionalTest.java @@ -117,7 +117,7 @@ void shouldStartJobAndRetrieveResult() { assertThat(finishedJob.get().getShells()).isNotEmpty(); assertThat(finishedJob.get().getTombstones()).isEmpty(); assertThat(finishedJob.get().getSubmodels()).isEmpty(); - assertThat(finishedJob.get().getBpns()).isNotEmpty(); + assertThat(finishedJob.get().getBpns()).isEmpty(); assertThat(finishedJob.get().getJob()).isNotNull(); assertThat(finishedJob.get().getJob().getSummary()).isNotNull(); assertThat(finishedJob.get().getJob().getParameter()).isNotNull();