Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: no secret scanning by KICS #167

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Conversation

scherersebastian
Copy link
Member

@scherersebastian scherersebastian commented Sep 17, 2023

Yo, yo, listen up, I got a tale to tell,
'Bout how our dev game is ringin' like a bell.
We're on this GitHub grind, pull requests in flight,
But when it comes to scans, man, somethin' ain't right.

Listen, y'all ambitious, that's cool, no debate,
But double, triple scans? Man, let's set this straight.
Veracode, Spotbugs, doing their dance,
But why we got all three for a single PR glance?

Here's my proposition, let's trim it lean,
Drop Veracode and Spotbugs, let CodeQL be the queen.
Security's important, that's the universal rule,
But PR after PR, we lookin' like a fool.

Secret Scan on the PR, that's all we need,
Let the rest run at night, let our main branch breathe.
So what y'all say? Time to make our move,
A bit of fun's essential when we're in the dev groove.

Open to suggestions, let's discuss this play,
But remember, we're here to innovate, not delay.
So drop a comment, let me hear your voice,
Are we cool with CodeQL? Y'all, it's time to make a choice.

@sonarcloud
Copy link

sonarcloud bot commented Sep 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@ds-jhartmann ds-jhartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion! We will look into further optimization of our workflows in the future. There is definitely room for improvement.

@ds-jhartmann ds-jhartmann merged commit 96dee55 into main Oct 4, 2023
18 checks passed
@ds-jhartmann ds-jhartmann deleted the scherersebastian-patch-1 branch October 4, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants