API documentation, testdata and registry client library #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent-1.3.2-SNAPSHOT Update irs-registry-client to 1.3.2-SNAPSHOT
Update DEPENDENCIES
chore(testing): update ESS investigation request
…-edc-client, irs-models and irs-testing
…-edc-client, irs-models and irs-testing
feat(impl):[TRI-1716] 1.6.2 datasets
chore(testing): Update DIL requests
…t and dependencies
… with not generated values
…-documentation-with-example-value feat:[TRI-1685]: added example values to open api yaml, fixed problem…
Update DEPENDENCIES
…scription to "samm" in testdataset
…ts-in-testdatafile-to-samm TRI-1716: adjusted URN of affected aspects to "urn:samm..."
…library-release Feature/tri 1468 enable full library release
Update DEPENDENCIES
ds-jhartmann
changed the title
mkanal
approved these changes
Oct 26, 2023
| public class Permission { | ||
|
|
||
| @Schema(implementation = PolicyType.class, example = "ACCESS") |
There was a problem hiding this comment.
can we use "USE" instead because that leads more to the use as access is directly handled by MIW and EDC. ACCESS policies are not used in this context.
|
|
||
| @NotNull | ||
| @Size(min = JOB_ID_FIELD_MAX_LENGTH, max = JOB_ID_FIELD_MAX_LENGTH) | ||
| @Schema(description = "Id of the job.", minLength = JOB_ID_FIELD_MAX_LENGTH, | ||
| maxLength = JOB_ID_FIELD_MAX_LENGTH, implementation = UUID.class, | ||
| pattern = "/^[0-9a-f]{8}-[0-9a-f]{4}-[0-5][0-9a-f]{3}-[089ab][0-9a-f]{3}-[0-9a-f]{12}$/i") | ||
| pattern = "/^[0-9a-f]{8}-[0-9a-f]{4}-[0-5][0-9a-f]{3}-[089ab][0-9a-f]{3}-[0-9a-f]{12}$/i", |
There was a problem hiding this comment.
recommendation to extract this into a static constant
| @Min(0) | ||
| @Max(Integer.MAX_VALUE) | ||
| private Integer depth; | ||
|
|
||
| @Schema(implementation = String.class) | ||
| @Schema(implementation = String.class, example = "BPNL00000003AYRE") |
There was a problem hiding this comment.
Using constants instead of stings in annotations?
| private BomLifecycle lifecycleContext; | ||
|
|
||
| @Schema(description = "Datetime of assembly.", implementation = ZonedDateTime.class) | ||
| @Schema(description = "Datetime of assembly.", implementation = ZonedDateTime.class, example = "2022-02-03T14:48:54.709Z") |
There was a problem hiding this comment.
using a constant - probably with a reason date
| @@ -37,11 +38,13 @@ public class MeasurementUnit { | |||
| /** | |||
| * dataTypeURI | |||
| */ | |||
| @Schema(implementation = String.class, example = "urn:bamm:io.openmanufacturing:meta-model:1.0.0#piece") | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: