Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge from CatenaX #413

Merged
merged 152 commits into from
Feb 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
152 commits
Select commit Hold shift + click to select a range
f7f4f3b
feat(impl):[#214] parallel findEndpointDataForConnectors returning fa…
dsmf Dec 19, 2023
a4bb6d3
feat(impl):[#214] add FastestResultFinder to irs-common module
dsmf Dec 21, 2023
901c7db
feat(impl):[#214] add logging of warnings to ResultFinder
dsmf Dec 21, 2023
c1c524f
feat(impl):[#214] add irs-common dependencies to irs-edc-client and i…
dsmf Dec 21, 2023
a83f905
Merge branch 'main' into feat/214-Dataspace-Discovery-Service-handle-…
dsmf Dec 21, 2023
66987e3
feat(impl):[#214] improve ResultFinder code
dsmf Dec 22, 2023
8f56c4d
feat(impl):[#214] remove Optional from return type
dsmf Dec 22, 2023
26daa2a
feat(impl):[#214] group tests by method name via @Nested
dsmf Dec 22, 2023
a614f98
feat(impl):[#214] undo f7f4f3bee3a3cf563f2cad63f5b8602218c8ca6c
dsmf Dec 22, 2023
ac52203
Merge branch 'main' into feat/214-Dataspace-Discovery-Service-handle-…
dsmf Jan 8, 2024
f360043
feat(impl):[#214] Handle multiple EDC URLs in DecentralDigitalTwinReg…
dsmf Jan 9, 2024
25ec678
Merge remote-tracking branch 'origin/main' into feat/214-Dataspace-Di…
dsmf Jan 9, 2024
1f61dab
feat(impl):[#214] fix checkstyle and pmd warnings
dsmf Jan 9, 2024
5eb0f74
feat(impl):[#214] fix pmd warnings
dsmf Jan 9, 2024
3c98757
feat(imp):[#214] improve variable naming for better readability
dsmf Jan 15, 2024
e7a8fe2
feat(imp):[#214] use completedFuture(null) instead of supplyAsync(() …
dsmf Jan 15, 2024
eb9f18c
feat(imp):[#214] exception handling for ResultFinder when all fail
dsmf Jan 15, 2024
705ae6b
feat(imp):[#214] exception handling for ResultFinder when all fail
dsmf Jan 15, 2024
3624c7e
feat(imp):[#214] reduce complexity by extraction of code to methods
dsmf Jan 15, 2024
99d6bfb
feat(imp):[#214] parallelize edcSubmodelFacade.getEndpointReferenceFo…
dsmf Jan 15, 2024
8b20334
Merge remote-tracking branch 'origin/main' into feat/214-Dataspace-Di…
dsmf Jan 16, 2024
11abe44
feat(imp):[#214] correct typo
dsmf Jan 16, 2024
1d85a2e
feat(imp):[#214] update deps
dsmf Jan 16, 2024
edb56af
Merge remote-tracking branch 'origin/main' into feat/214-Dataspace-Di…
dsmf Jan 17, 2024
2219b3b
feat(imp):[#214] update CHANGELOG.md
dsmf Jan 17, 2024
6909a46
feat(imp):[#214] improve readability
dsmf Jan 18, 2024
981a706
feat(imp):[#214] fix license header
dsmf Jan 18, 2024
641dd67
feat(imp):[#214] fix license header
dsmf Jan 18, 2024
0d2942e
feat(imp):[#214] improve readability
dsmf Jan 18, 2024
d844e70
feat(imp):[#214] fix PMD warning
dsmf Jan 18, 2024
6a117dd
feat(imp):[#214] improve readability and add some logging
dsmf Jan 18, 2024
8137cd2
feat(imp):[#214] improve readability
dsmf Jan 18, 2024
f080d72
feat(imp):[#214] add some logging
dsmf Jan 18, 2024
fe1f7c5
feat(irs-registry-client): Add wiremock tests for decentral registry …
ds-jhartmann Jan 18, 2024
18dd6ed
feat(imp):[#214] fix PMD warning
dsmf Jan 18, 2024
1eab989
feat(imp):[#214] update arc42 documentation
dsmf Jan 18, 2024
e3ebc1e
feat(imp):[#214] correct PlantUML diagrams
dsmf Jan 18, 2024
4b02479
feat(imp):[#214] refined arc42 documentation
dsmf Jan 18, 2024
8cb6954
feat(imp):[#214] convert diagram from #256 in arc42 documentation to …
dsmf Jan 18, 2024
3c50544
Merge branch 'main' into feat/214-Dataspace-Discovery-Service-handle-…
dsmf Jan 22, 2024
361ede9
Merge branch 'main' into feat/214-Dataspace-Discovery-Service-handle-…
dsmf Jan 23, 2024
40eba34
Merge branch 'main' into feat/214-Dataspace-Discovery-Service-handle-…
dsmf Jan 23, 2024
62cc323
feat(irs-api):[#344] Add wiremock test for BpdmFacade
ds-jhartmann Jan 23, 2024
57e09cd
feat(irs-api):[#344] Extract WireMockConfig to irs-testing
ds-jhartmann Jan 23, 2024
302ddd2
feat(irs-api):[#344] Extract WireMockConfig to irs-testing
ds-jhartmann Jan 23, 2024
d819516
feat(edc-client):[#344] Extend SubmodelFacadeWiremockTest
ds-jhartmann Jan 23, 2024
588b7bd
feat(edc-client):[#344] Extend SemanticHubWiremockTest
ds-jhartmann Jan 23, 2024
4125ea9
feat(edc-client):[#344] Add IrsWireMock integration test
ds-jhartmann Jan 23, 2024
8032c80
Merge branch 'main' into feat/214-Dataspace-Discovery-Service-handle-…
dsmf Jan 23, 2024
efb20dd
feat(imp):[#214] fix license header and merge conflict compile problem
dsmf Jan 23, 2024
8dbff36
feat(imp):[#214] add some error logging
dsmf Jan 23, 2024
d51f6ab
feat(imp):[#214] debug logging for investigation on DEV
dsmf Jan 23, 2024
7a7324b
feat(imp):[#214] fix checkstyle warning
dsmf Jan 23, 2024
824d1d9
feat(imp):[#214] debug logging (to be removed/adapted after debugging)
dsmf Jan 24, 2024
6fb3b3a
Merge remote-tracking branch 'origin/main' into feat/214-Dataspace-Di…
dsmf Jan 24, 2024
e3bb440
feat(imp):[#214] add stop watches for analyzing performance
dsmf Jan 24, 2024
0d30613
feat(irs-test):[#344] Create reusable wiremock config
ds-jhartmann Jan 25, 2024
3a8469c
feat(irs):[#249] extend policies structure
ds-psosnowski Jan 25, 2024
b0b5153
feat(irs):[#249] merge main
ds-psosnowski Jan 25, 2024
90995dd
feat(imp):[#214] catching any runtime exception to avoid hanging jobs
dsmf Jan 25, 2024
30b3d9b
feat(irs):[#249] added tests
ds-psosnowski Jan 26, 2024
34b1f36
feat(irs):[#249] removed unused import
ds-psosnowski Jan 26, 2024
dc7b67e
feat(irs):[#249] updated changelog
ds-psosnowski Jan 26, 2024
9a53cfd
Merge branch 'main' into feat/214-Dataspace-Discovery-Service-handle-…
dsmf Jan 26, 2024
672d797
feat(imp):[#214] improve exception handling
dsmf Jan 26, 2024
d1fd503
feat(irs-api):[#344] Add Irs WireMock Test simulating one level
ds-jhartmann Jan 26, 2024
fd954af
feat(irs):[#249] fixed conflicts
ds-psosnowski Jan 26, 2024
265a177
feat(irs):[#249] added missing white space
ds-psosnowski Jan 26, 2024
002b5d0
feat(irs):[#249] added missing white space
ds-psosnowski Jan 26, 2024
ff326e0
Revert "Revert "feat(impl):[#378] separate credentials config""
ds-ext-kmassalski Jan 26, 2024
a262bab
feat(irs-testing):[#344] Fix code smells
ds-jhartmann Jan 29, 2024
33945ee
Merge branch 'main' into feature/#344-integration-tests
ds-jhartmann Jan 29, 2024
b557774
feat(irs-api):[#344] Fix test execution and added test cases
ds-jhartmann Jan 29, 2024
9d2e294
chore(foss):[#344] Fix license headers
ds-jhartmann Jan 29, 2024
60d7810
chore(foss):[#344] Update DEPENDENCIES
ds-jhartmann Jan 29, 2024
91c4e88
chore(foss):[#344] Update dash license-tool-plugin
ds-jhartmann Jan 29, 2024
9b119bb
Add contact section to Update README.md
mkanal Jan 30, 2024
44bed78
feat(irs-api):[#344] Add test case for recursive IRS flow
ds-jhartmann Jan 30, 2024
607faa0
chore(docs):[#344] Add changes to CHANGELOG.md
ds-jhartmann Jan 30, 2024
c455751
chore(foss):[#344] Update DEPENDENCIES
ds-jhartmann Jan 30, 2024
2964eec
feat(irs-api):[#344] Delete unused files
ds-jhartmann Jan 30, 2024
505fa27
feat(irs-api):[#344] Add test case for recursive IRS flow
ds-jhartmann Jan 30, 2024
1d7fce6
feat(impl):[#370] impl adding contract agreement id
ds-ext-kmassalski Jan 30, 2024
b3915c0
feat(impl):[#370] changelog
ds-ext-kmassalski Jan 30, 2024
d9fc950
feat(impl):[#370] fix pmd
ds-ext-kmassalski Jan 31, 2024
62ccdb9
chore():[#000] Add contact information to Update README.md
mkanal Jan 31, 2024
eb69da9
feat(impl):[#370] fix spotbugs
ds-ext-kmassalski Jan 31, 2024
979db22
chore(irs):[#207] prepare concept for redisign metrics used in summar…
ds-psosnowski Jan 31, 2024
296ce97
chore(irs):[#207] added title
ds-psosnowski Jan 31, 2024
86b7662
fix(charts): Add missing configuration for discovery oAuthClientId
ds-jhartmann Jan 31, 2024
a0995ef
fix(irs-api): Change default oAuthClientId of digitalTwinRegistry to …
ds-jhartmann Jan 31, 2024
ddb1f2e
fix(irs-api): Add separate configuration for discovery finder rest te…
ds-jhartmann Jan 31, 2024
6a27805
fix(charts): Add missing configuration for discovery finder
ds-jhartmann Jan 31, 2024
a714996
docs(changelog): update CHANGELOG.md
ds-jhartmann Jan 31, 2024
8f36c1d
Update README.md
mkanal Jan 31, 2024
49f1da9
Merge pull request #747 from catenax-ng/chore/#000-add-contact-inform…
ds-jhartmann Jan 31, 2024
8aa4c4b
Merge branch 'main' into feat/214-Dataspace-Discovery-Service-handle-…
dsmf Jan 31, 2024
8b9bbad
feat(irs):[#249] fixed sonar issues
ds-psosnowski Jan 31, 2024
171ca93
fix(charts): Fix config map structure
ds-jhartmann Jan 31, 2024
565103e
fix(irs-api): Change bean name to @Bean(name) instead of @Qualifier(n…
ds-jhartmann Jan 31, 2024
a6e4288
feat(imp):[#214] Cleanup
dsmf Jan 31, 2024
bbc1464
feat(irs):[#249] pmd fix
ds-psosnowski Jan 31, 2024
dceda1f
feat(impl):[#370] add unit test
ds-ext-kmassalski Jan 31, 2024
7326f50
Merge pull request #739 from catenax-ng/feature/#249-extend-policies-…
ds-psosnowski Jan 31, 2024
7b2b9b4
feat(impl):[#370] try report aggregate
ds-ext-kmassalski Jan 31, 2024
e9b9c36
feat(impl):[#370] merge main
ds-ext-kmassalski Jan 31, 2024
622ea73
feat(impl):[#370] catch UsagePolicyExc in RelationshipDelegate
ds-ext-kmassalski Jan 31, 2024
5c5d5c8
feat(impl):[#370] catch UsagePolicyExc in RelationshipDelegate
ds-ext-kmassalski Jan 31, 2024
cb86a95
feat(imp):[#214] Update glossary
dsmf Jan 31, 2024
5a02803
feat(imp):[#214] Improve glossary
dsmf Jan 31, 2024
806dedb
feat(imp):[#214] Move logging to business classes and remove some deb…
dsmf Feb 1, 2024
f94838e
feat(imp):[#214] fix MD034 linting errors
dsmf Feb 1, 2024
b5e29e1
feat(imp):[#214] cleanup logging
dsmf Feb 1, 2024
7a8b34d
feat(irs):[#249] added policy for null fields
ds-psosnowski Feb 1, 2024
a72d875
feat(irs):[#249] changed return type of get all policies to match new…
ds-psosnowski Feb 1, 2024
27863d6
Merge remote-tracking branch 'origin/fix/add-missing-configuration' i…
ds-jhartmann Feb 1, 2024
090c192
chore(charts): add missing templates for oauth ids
ds-jhartmann Feb 1, 2024
0f20f6c
feat(irs):[#249] added example payload for get all policies response
ds-psosnowski Feb 1, 2024
2ac70fb
Merge branch 'main' into revert-741-revert-737-feature/378-separate-c…
ds-jhartmann Feb 1, 2024
e13eb7e
Merge remote-tracking branch 'origin/main' into feat/214-Dataspace-Di…
dsmf Feb 1, 2024
8be2410
feat(testing):[#344] Renaming *WireMockConfig to *WireMockSupport, re…
ds-jhartmann Feb 1, 2024
d323587
feat(testing):[#344] Renaming *WireMockConfig to *WireMockSupport, re…
ds-jhartmann Feb 1, 2024
c7c4aaf
docs(testing):[#344] Add issue id to todos
ds-jhartmann Feb 2, 2024
2be68b5
Merge pull request #744 from catenax-ng/feature/#344-integration-tests
ds-jhartmann Feb 2, 2024
7b4ad06
feat(impl):[#370] merge main
ds-ext-kmassalski Feb 2, 2024
75a1632
feat(impl):[#370] fix test
ds-ext-kmassalski Feb 2, 2024
ae63bea
feat(impl):[#370] fix test
ds-ext-kmassalski Feb 2, 2024
0cfba0f
feat(imp):[#214] improved variable naming and code comment
dsmf Feb 2, 2024
ae79585
feat(imp):[#214] remove superfluous log
dsmf Feb 2, 2024
b2684ac
Merge remote-tracking branch 'origin/main' into feat/214-Dataspace-Di…
dsmf Feb 2, 2024
b635caf
feat(imp):[#214] fix tests
dsmf Feb 2, 2024
b81fc36
Merge pull request #711 from catenax-ng/feat/214-Dataspace-Discovery-…
dsmf Feb 2, 2024
137fd7e
feat(impl):[#370] main merge
ds-ext-kmassalski Feb 5, 2024
995284a
Merge pull request #746 from catenax-ng/feature/370-impl-adding-contr…
ds-ext-kmassalski Feb 5, 2024
8e8caed
feat(irs):[#249] added missing createdOn, updated insomnia collection
ds-psosnowski Feb 5, 2024
ab0c158
feat(irs):[#249] shorten to list in stream in policy controller
ds-psosnowski Feb 5, 2024
465ca26
feat(irs):[#249] import fix
ds-psosnowski Feb 5, 2024
d1c34aa
feat(imp):[#214] Remove obsolete TODO
dsmf Feb 5, 2024
66c68aa
Merge pull request #752 from catenax-ng/feature/#249-extend-policies-…
ds-psosnowski Feb 5, 2024
e7a4ef8
feat(irs):[#207] added more info to concept
ds-psosnowski Feb 5, 2024
868cd52
chore(tests):[#xxx] Test method naming following Google Style Guide
dsmf Feb 5, 2024
d0c51c3
chore(tests):[#xxx] Test method naming following Google Style Guide
dsmf Feb 5, 2024
13812d6
Merge pull request #757 from catenax-ng/chore/change-test-method-nami…
dsmf Feb 5, 2024
c1116db
feat(testing):[370] created tavern tests for checking contractAgreeme…
ds-alexander-bulgakov Feb 6, 2024
f73d5c2
Merge pull request #748 from catenax-ng/chore/#207-redisign-metrics-u…
ds-psosnowski Feb 6, 2024
a46176c
Merge branch 'main' into revert-741-revert-737-feature/378-separate-c…
ds-jhartmann Feb 6, 2024
2d7ad3f
Merge pull request #742 from catenax-ng/revert-741-revert-737-feature…
ds-jhartmann Feb 6, 2024
4c28b29
Revert "Revert "Revert "feat(impl):[#378] separate credentials config"""
ds-jhartmann Feb 6, 2024
d7bfe06
Merge pull request #758 from catenax-ng/revert-742-revert-741-revert-…
ds-jhartmann Feb 6, 2024
83d31d2
Merge pull request #760 from catenax-ng/feature/#370-add-tavern-tests…
ds-alexander-bulgakov Feb 6, 2024
4317ccc
Merge branch 'main' into chore/#581-add-matrix-chat
ds-mmaul Feb 6, 2024
3974db0
Merge pull request #761 from catenax-ng/chore/#581-add-matrix-chat
ds-mmaul Feb 6, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,18 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Added
- Added helper script for building documentation locally.
- Added new job parameter flag "auditContractNegotiation" which toggles setting contractAgreementId in Shells and Submodels
- Added "contractAgreementId" field to Submodel model
- Added Integration Tests for the entire IRS flow using stubbed responses of Discovery Service, Semantic Hub, EDC, Digital Twin Registry and BPDM Pool

### Changed

- Dataspace Discovery Service handles multiple EDC-Urls received for BPN now
- Updated license header to "Copyright (c) 2021,2024 Contributors to the Eclipse Foundation"
- Changed lookupGlobalAssetIds to lookupShellsByBPN, which provides full object.
- Suppressed CVE-2024-20932 from graal-sdk-21.2.0.jar because this is not applicable for IRS.
- Redesigned Shell object - wrapped payload and added "contractAgreementId" field
- Changed structure of Policy creation to match EDC format

### Fixed
- Update to Spring Boot 3.1.8. This fixes the following CVEs:
Expand Down
11 changes: 5 additions & 6 deletions DEPENDENCIES
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,6 @@ maven/mavencentral/net.minidev/accessors-smart/2.4.9, Apache-2.0, approved, #751
maven/mavencentral/net.minidev/json-smart/2.4.10, Apache-2.0, approved, #3288
maven/mavencentral/net.minidev/json-smart/2.4.11, Apache-2.0, approved, #3288
maven/mavencentral/net.sf.saxon/Saxon-HE/10.6, MPL-2.0 AND W3C, approved, #7945
maven/mavencentral/org.apache.commons/commons-compress/1.23.0, Apache-2.0 AND BSD-3-Clause, approved, #7506
maven/mavencentral/org.apache.commons/commons-compress/1.24.0, Apache-2.0 AND BSD-3-Clause AND bzip2-1.0.6 AND LicenseRef-Public-Domain, approved, #10368
maven/mavencentral/org.apache.commons/commons-lang3/3.12.0, Apache-2.0, approved, clearlydefined
maven/mavencentral/org.apache.commons/commons-pool2/2.11.1, Apache-2.0, approved, CQ23795
Expand Down Expand Up @@ -325,11 +324,11 @@ maven/mavencentral/org.eclipse.jetty/jetty-xml/11.0.17, EPL-2.0 OR Apache-2.0, a
maven/mavencentral/org.eclipse.jetty/jetty-xml/11.0.19, EPL-2.0 OR Apache-2.0, approved, rt.jetty
maven/mavencentral/org.eclipse.tractusx.irs/irs-api/0.0.2-SNAPSHOT, Apache-2.0, approved, automotive.tractusx
maven/mavencentral/org.eclipse.tractusx.irs/irs-common/0.0.2-SNAPSHOT, Apache-2.0, approved, automotive.tractusx
maven/mavencentral/org.eclipse.tractusx.irs/irs-edc-client/1.5.1-SNAPSHOT, Apache-2.0, approved, automotive.tractusx
maven/mavencentral/org.eclipse.tractusx.irs/irs-models/1.5.1-SNAPSHOT, Apache-2.0, approved, automotive.tractusx
maven/mavencentral/org.eclipse.tractusx.irs/irs-edc-client/1.5.2-SNAPSHOT, Apache-2.0, approved, automotive.tractusx
maven/mavencentral/org.eclipse.tractusx.irs/irs-models/1.5.2-SNAPSHOT, Apache-2.0, approved, automotive.tractusx
maven/mavencentral/org.eclipse.tractusx.irs/irs-policy-store/0.0.2-SNAPSHOT, Apache-2.0, approved, automotive.tractusx
maven/mavencentral/org.eclipse.tractusx.irs/irs-registry-client/1.5.1-SNAPSHOT, Apache-2.0, approved, automotive.tractusx
maven/mavencentral/org.eclipse.tractusx.irs/irs-testing/1.5.1-SNAPSHOT, Apache-2.0, approved, automotive.tractusx
maven/mavencentral/org.eclipse.tractusx.irs/irs-registry-client/1.5.2-SNAPSHOT, Apache-2.0, approved, automotive.tractusx
maven/mavencentral/org.eclipse.tractusx.irs/irs-testing/1.5.2-SNAPSHOT, Apache-2.0, approved, automotive.tractusx
maven/mavencentral/org.glassfish.hk2.external/aopalliance-repackaged/3.0.4, EPL-2.0 OR GPL-2.0-only with Classpath-exception-2.0, approved, ee4j.glassfish
maven/mavencentral/org.glassfish.hk2.external/aopalliance-repackaged/3.0.5, EPL-2.0 OR GPL-2.0-only with Classpath-exception-2.0, approved, ee4j.glassfish
maven/mavencentral/org.glassfish.hk2/hk2-api/3.0.4, EPL-2.0 OR GPL-2.0-only with Classpath-exception-2.0, approved, ee4j.glassfish
Expand Down Expand Up @@ -473,7 +472,7 @@ maven/mavencentral/org.testcontainers/testcontainers/1.19.1, Apache-2.0 AND MIT,
maven/mavencentral/org.typelevel/spire-macros_2.13/0.17.0, MIT, approved, clearlydefined
maven/mavencentral/org.unbescape/unbescape/1.1.6.RELEASE, Apache-2.0, approved, CQ18904
maven/mavencentral/org.webjars/swagger-ui/5.2.0, Apache-2.0, approved, #10221
maven/mavencentral/org.wiremock/wiremock-standalone/3.2.0, MIT AND Apache-2.0, approved, #10919
maven/mavencentral/org.wiremock/wiremock-standalone/3.3.1, MIT AND Apache-2.0, approved, #12941
maven/mavencentral/org.xerial.snappy/snappy-java/1.1.10.5, Apache-2.0 AND (Apache-2.0 AND BSD-3-Clause), approved, #9098
maven/mavencentral/org.xmlunit/xmlunit-core/2.9.1, Apache-2.0, approved, #6272
maven/mavencentral/org.yaml/snakeyaml/1.33, Apache-2.0, approved, clearlydefined
Expand Down
7 changes: 7 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -152,3 +152,10 @@ from the base distribution, along with any direct or indirect dependencies of th

As for any pre-built image usage, it is the image user's responsibility to ensure that any use of this image complies
with any relevant licenses for all software contained within.

## Contact

Contact the project developers via the project's "dev" list.

* https://accounts.eclipse.org/mailing-list/tractusx-dev
* Eclipse Matrix Chat https://chat.eclipse.org/#/room/#tractusx-irs:matrix.eclipse.org
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
# \[Concept\] \[#207\] Redesign metrics used in summary inside Job Response

| Key | Value |
|---------------|-------------------------------------------------------------------------------|
| Creation date | 31.01.2024 |
| Ticket Id | #207 https://github.com/eclipse-tractusx/item-relationship-service/issues/207 |
| State | DRAFT |

## Table of Contents

1. [Overview](#overview)
2. [Problem Statement](#problem-statement)
3. [Concept](#concept)

## Overview
Currently summary section of a JobResponse contains information about asyncFetchedItems which covers DigitalTwin Registry requests responses and Submodel Server requests responses.
Results are shown together for both of mentioned responses:
```
"summary": {
"asyncFetchedItems": {
"completed": 1,
"failed": 0,
"running": 0
}
}
```

## Problem Statement
We would like to have separate summary response for DigitalTwin Registry requests and Submodel Server.
Also there should be information about actual tree depth for given JobResponse.

## Concept
This diagram shows current flow:
![alt text](https://eclipse-tractusx.github.io/item-relationship-service/docs/arc42/architecture-constraints/execute-job.svg)

Steps number 4 and 6 are respectively requesting AAS and Submodel. Then both are stored in BlobStore by method `addTransferProcess` in `JobStore`.
They should be distinguished by the type, so when step 12 (complete) is executed we can query the store for completed, failed and running items and add them to the response by type.
```
"summary": {
"asyncFetchedItemsRegistry": {
"running": 0,
"completed": 1,
"failed": 1
},
"asyncFetchedItemsSubmodelServer": {
"running": 0,
"completed": 1,
"failed": 1
}
},
```
Tree is stored as list of nodes in list of Relationships as filed `private List<Relationship> relationships;` in `ItemContainer`.
Tree is assebmled in class `ItemTreesAssembler` in method `retrieveItemGraph`.
We should get the depth of the tree and add it to the response. Consider using https://www.geeksforgeeks.org/depth-n-ary-tree/
Important to note that determining the depth of a running job like this is only suitable as some sort of progress bar. The actual "completion by depth" criteria still has to be evaluated in the DigitalTwinDelegate and needs to be done independently for every branch of the tree
Loading
Loading