Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/393 readme improvements #456
Feature/393 readme improvements #456
Changes from 66 commits
f785ee8
0d749c8
96a5d2f
b840cc0
89547da
0485e21
917c80e
a81e078
e911a2a
8ec9686
0c7d974
ae80eae
c5d22b4
e1c4f09
036e4b6
bdaf845
a30d28d
c5dfe2d
a3d476d
eea3a1a
5698a2d
58e22dd
69225fe
50dc51a
4375796
a1020a0
6f922fe
6eab8f5
0a04e49
24d4cf4
d1eecaa
1adef1d
2b0918d
b67953c
e791fdc
4497a0b
72c2f1d
872f164
666dcb8
0a4ac5a
e2ee4bd
5982d83
723127d
ba31187
22d8ca6
9a17e96
7d5412a
8eeb322
770e81f
bd5aead
eec7d3b
8fd32ac
9e94015
3aa45a9
0b88ed3
a74d252
8f2710c
c07fcd9
b899dcc
61d6509
b785eb6
bf6a959
c7746ac
6996e27
5a87e99
e835a9c
89e38ef
8aec98d
900ef0b
0e449de
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would not focus on documentation - general contribution is not limited to this. I would not recommend explaining this too deeply. General link to issues and discussions are sufficient. In case labels or other things change these links were useless.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mkanal, What else would you see as a "General Contribution"? I mean there are also the sections "Contributing as a Consultant" and "Contributing as a Developer" which cover all other kind of contributions I can think of at the moment. If we remove what I have added here we would end up with an empty section as it was before (see branch main)... so IMHO we should remove the heading "General Contribution to the Project" completely or add something meaningful here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GitHub provided navigation within the project - this is not necessery IMHO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes but not the IDE, developers will probably navigate in the IDE and not on github, at least that's what I do
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean by GitHub provided navigation in the Project? I like the reference to the parent document. This makes navigation in the browser as well as in the IDE easier.