Feat/395 edc client handle multiple dt rs and d ts #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partial implementation started in context of #214 before story was split up. This commit is just meant to back up the work. It is neither complete nor does it work yet and it still contains compile errors.
this code place is not related to this story
edcRestTemplate is correct here, because we communicate with a DTR via an EDC
- better variable/parameter naming - split up stream expression into multiple lines - add helpful code comments to each part - reference special scenario diagram
And remove test concerning InterruptedException which is no longer relevant in this place.
…andle-multiple-DTRs-and-DTs
by accessing EndpointDataReferenceStorage via EndpointDataReferenceCacheService only
…andle-multiple-DTRs-and-DTs
Already removed dependency to EndpointDataReferenceStorage in previous commits. In order to reduce more imports more refactoring would be required which is far beyond the scope of the current story.
…andle-multiple-DTRs-and-DTs
…andle-multiple-DTRs-and-DTs # Conflicts: # CHANGELOG.md
this file had been committed accidently
…andle-multiple-DTRs-and-DTs # Conflicts: # irs-api/src/main/java/org/eclipse/tractusx/irs/aaswrapper/job/delegate/RelationshipDelegate.java
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| @ParameterizedTest(name = "{0}") | ||
| @ArgumentsSource(NoOrFailedEndpointDataReferenceProvider.class) | ||
| void lookupShellIdentifiers_multipleEDCs_oneDTR(String title, |
Check notice
Code scanning / CodeQL
Useless parameter
|
|
||
| @ParameterizedTest(name = "{0}") | ||
| @ArgumentsSource(NoOrFailedEndpointDataReferenceProvider.class) | ||
| void lookupShellIdentifiers_multipleEDCs_oneDTR(String title, |
Check notice
Code scanning / CodeQL
Useless parameter Note test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: