Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Proper release workflow #727

Conversation

ds-pweick
Copy link
Contributor

@ds-pweick ds-pweick commented Jun 25, 2024

Description

This PR changes the workflow release.yml in that the workflow now performs what was previously done via a separate workflow update-docs-for-release.yml which updated the docs upon release.

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

run: sed -i "s|${{ steps.main-changelog-update.outputs.previous-irs-version }}|${{ inputs.irs-version }}|" ${{ env.IRS_APPLICATION_PATH }}

- name: Update irs-api.yaml
uses: mikefarah/yq@v4.44.2

Check notice

Code scanning / KICS

Unpinned Actions Full Length Commit SHA Note

Action is not pinned to a full length commit SHA.
@ds-pweick ds-pweick marked this pull request as ready for review June 25, 2024 09:20
@ds-pweick ds-pweick marked this pull request as draft June 26, 2024 05:46
@ds-pweick ds-pweick marked this pull request as ready for review June 26, 2024 06:26
.github/workflows/release.yaml Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@ds-pweick ds-pweick marked this pull request as draft July 3, 2024 07:31
run: sed -i "s|${{ steps.main-changelog-update.outputs.previous-irs-version }}|${{ inputs.irs-version }}|" ${{ env.IRS_APPLICATION_PATH }}

- name: Update irs-api.yaml
uses: mikefarah/yq@v4.44.2

Check notice

Code scanning / KICS

Unpinned Actions Full Length Commit SHA

Action is not pinned to a full length commit SHA.
@ds-pweick ds-pweick marked this pull request as ready for review July 3, 2024 15:02
@ds-jhartmann ds-jhartmann changed the base branch from main to chore/improved-release-workflow July 12, 2024 12:21
Copy link
Contributor

@ds-jhartmann ds-jhartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ds-jhartmann ds-jhartmann merged commit 5ea1f3b into eclipse-tractusx:chore/improved-release-workflow Jul 12, 2024
15 of 16 checks passed
ds-jhartmann pushed a commit that referenced this pull request Jul 12, 2024
* refactor(release): improve release workflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants