Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/226 test enhancements for integration testing #732

Merged

Conversation

ds-jhartmann
Copy link
Contributor

@ds-jhartmann ds-jhartmann commented Jun 26, 2024

Description

This PR introduces new GitHub workflows for E2E Tests using the Umbrella Helm Chart as well as a GitHub action to setup the umbrella environment which can be reused in other workflows.
Test data needed to be adjusted since the Umbrella setup only allows EDCs to process requests for their actual BPN. So all BPNs in the test data files now point to the same BPN

A cucumber and tavern test workflow was prepared to execute the tests against umbrella environment.

Most tests are passing as you can see in the summaries on my fork, but the ESS cases still needs further configuration to work properly
Tavern: https://github.com/ds-jhartmann/item-relationship-service/actions/runs/9808714509
Cucumber: https://github.com/ds-jhartmann/item-relationship-service/actions/runs/9807918899

The PR also includes a small change in the validation for EDC URLs received by EDC Discovery or Digital Twin Registry, so it is no longer failing on .test and internal URLs.

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@ds-jhartmann ds-jhartmann force-pushed the feature/226-test-enhancements-for-integration-testing branch from d9a64d9 to 4dec8f6 Compare July 3, 2024 14:03
ds-jhartmann added a commit that referenced this pull request Jul 3, 2024
ds-jhartmann added a commit that referenced this pull request Jul 3, 2024
Copy link

gitguardian bot commented Jul 3, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

ds-jhartmann added a commit that referenced this pull request Jul 4, 2024
sed "s/access_tok.*:s = '.*'//g" tavern-results.xml | sed "s/Authorization: Bearer .*/Authorization:/g" | uniq > result.xml

- name: Publish Tavern Results
uses: EnricoMi/publish-unit-test-result-action@v2.16.1

Check notice

Code scanning / KICS

Unpinned Actions Full Length Commit SHA Note

Action is not pinned to a full length commit SHA.
sed "s/access_tok.*:s = '.*'//g" tavern-ess-results.xml | sed "s/Authorization: Bearer .*/Authorization:/g" | uniq > ess-result.xml

- name: Publish Tavern Results
uses: EnricoMi/publish-unit-test-result-action@v2.16.1

Check notice

Code scanning / KICS

Unpinned Actions Full Length Commit SHA Note

Action is not pinned to a full length commit SHA.
ds-jhartmann added a commit that referenced this pull request Jul 5, 2024
@ds-jhartmann ds-jhartmann marked this pull request as ready for review July 5, 2024 12:06
@ds-jhartmann ds-jhartmann requested a review from dsmf July 5, 2024 12:19
@ds-jhartmann ds-jhartmann force-pushed the feature/226-test-enhancements-for-integration-testing branch from efae970 to 4a7e4ee Compare July 5, 2024 14:08
Copy link
Contributor

@dsmf dsmf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ds-lcapellino ds-lcapellino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sed "s/access_tok.*:s = '.*'//g" tavern-ess-results.xml | sed "s/Authorization: Bearer .*/Authorization:/g" | uniq > ess-result.xml

- name: Publish Tavern Results
uses: EnricoMi/publish-unit-test-result-action@v2.16.1

Check notice

Code scanning / KICS

Unpinned Actions Full Length Commit SHA Note

Action is not pinned to a full length commit SHA.
sed "s/access_tok.*:s = '.*'//g" tavern-ess-results.xml | sed "s/Authorization: Bearer .*/Authorization:/g" | uniq > ess-result.xml

- name: Publish Tavern Results
uses: EnricoMi/publish-unit-test-result-action@v2.16.1

Check notice

Code scanning / KICS

Unpinned Actions Full Length Commit SHA Note

Action is not pinned to a full length commit SHA.
Copy link

sonarcloud bot commented Jul 25, 2024

@ds-jhartmann ds-jhartmann merged commit 3837c62 into main Jul 25, 2024
20 checks passed
@ds-jhartmann ds-jhartmann deleted the feature/226-test-enhancements-for-integration-testing branch July 25, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants