fix(irs-api):[#755] fix job callbacks called multiple times after com…

[ds-jhartmann]

…pletion

Description

• fix job callbacks called multiple times after completion Duplicate callbacks for jobs received #755

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

• DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
• Copyright and license header are present on all affected files

[github-actions]

Test Results

35 tests   - 1   34 ✅ +17   5m 18s ⏱️ - 1h 37m 46s
 1 suites ±0    0 💤 ± 0 
 1 files   ±0    1 ❌  - 18 

For more details on these failures, see this check.

Results for commit eb6794e. ± Comparison against base commit ee0845a.

This pull request removes 6 and adds 5 tests. Note that renamed tests count towards both.

BomLifecycle 'asPlanned' implementation ‑ End 2 End for BomLifecycle 'asPlanned' Vehicle Model B for MercedesBenz [BPNL00000003AVTH]
BomLifecycle 'asPlanned' implementation ‑ End 2 End for BomLifecycle 'asPlanned' Vehicle Model C for SAP [BPNL00000003AZQP]
IRS support for different aspect models ‑ BomLifecycle 'asBuilt' for testing "Batch"-Model [BPNL00000003B5MJ]
IRS support for different aspect models ‑ BomLifecycle 'asBuilt' for testing "JustInSequencePart-Model [BPNL00000000BJTL]
SingleLevelUsageAsBuilt ‑ End 2 End for OEM-B (MB) [BPN:BPNL00000003AVTH] (SerialPart 3.0.0, SingleLevelBomAsBuilt 3.0.0 , Batch 3.0.0)
SingleLevelUsageAsBuilt ‑ End 2 End for Tier A (ZF) [BPN:BPNL00000003B2OM] (SerialPart 3.0.0, SingleLevelBomAsBuilt 3.0.0 , Batch 3.0.0)

BomLifecycle 'asPlanned' implementation ‑ End 2 End for BomLifecycle 'asPlanned' Vehicle Model B for MercedesBenz [BPNL00000003AYRE]
BomLifecycle 'asPlanned' implementation ‑ End 2 End for BomLifecycle 'asPlanned' Vehicle Model C for SAP [BPNL00000003AYRE]
IRS support for different aspect models ‑ BomLifecycle 'asBuilt' for testing "Batch"-Model [BPNL00000003AYRE]
IRS support for different aspect models ‑ BomLifecycle 'asBuilt' for testing "JustInSequencePart-Model [BPNL00000003AYRE]
SingleLevelUsageAsBuilt ‑ End 2 End for Tier A (ZF) [BPN:BPNL00000003AYRE] (SerialPart 3.0.0, SingleLevelBomAsBuilt 3.0.0 , Batch 3.0.0)

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
91.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[dsmf]

LGTM

[ds-lcapellino]

Is this also checked when creating a job? And if so, is the double check necessary?

[ds-jhartmann]

The callback URL is only validated for right protocol at job creation.
Perhaps it would make more sense to validate the URL at job creation instead of when the callback is executed but that goes beyond the scope of this bug

[ds-lcapellino]

LGTM