Fix/841 fill bpn in tombstone #863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ods as deprecated use builder instead, even though this will be more eloquent it will be more flexible and easier to understand and change
…to EdcRetrieverException, add builder
…erException single field builder and private setters in the class are sufficient here and reduce amount of boilerplate code
…test - Use the new EdcRetrieverException.Builder. - Add endpoint url(s) and BPN in some places. - Enhance tests. - Remove the constructor methods Tombstone.from. Builder is used now. - General code cleanup and formatting improvements across multiple test and implementation classes to enhance readability and maintainability including extraction of code to methods.
…ve test readability
ds-jhartmann
requested changes
Aug 2, 2024
...c/test/java/org/eclipse/tractusx/irs/registryclient/decentral/EdcRetrieverExceptionTest.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/eclipse/tractusx/irs/testing/wiremock/DiscoveryServiceWiremockSupport.java
Show resolved
Hide resolved
...src/main/java/org/eclipse/tractusx/irs/testing/wiremock/DiscoveryServiceWiremockSupport.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/eclipse/tractusx/irs/testing/wiremock/DiscoveryServiceWiremockSupport.java
Outdated
Show resolved
Hide resolved
...api/src/main/java/org/eclipse/tractusx/irs/aaswrapper/job/delegate/RelationshipDelegate.java
Show resolved
Hide resolved
irs-api/src/main/java/org/eclipse/tractusx/irs/aaswrapper/job/delegate/DigitalTwinDelegate.java
Outdated
Show resolved
Hide resolved
replace tabs with spaces
…emock/DiscoveryServiceWiremockSupport.java Co-authored-by: Jaro Hartmann <57985712+ds-jhartmann@users.noreply.github.com>
…nto fix/841-fill-bpn-in-tombstone
dsmf
commented
Aug 2, 2024
| assertThat(actualTombstone.getBusinessPartnerNumber()).isEqualTo(TEST_BPN); | ||
| assertThat(actualTombstone.getEndpointURL()).describedAs("Tombstone should contain all EDC URLs") | ||
| .isEqualTo(String.join("; ", edcUrls)); | ||
|
|
There was a problem hiding this comment.
@ds-jhartmann when I add the following assertions
assertThat(rootCauses).hasSize(edcUrls.size());
edcUrls.forEach(edcUrl -> assertThat(rootCauses).anyMatch(rootCause -> rootCause.contains(edcUrl)));
this fails. It seems that getting the root causes is somehow incomplete?!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: