Skip to content

Commit

Permalink
fix: sonar issues
Browse files Browse the repository at this point in the history
  • Loading branch information
nitin-vavdiya committed May 28, 2024
1 parent bd07141 commit 7d75be3
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,6 @@ public static void makeFilterWorkForHolder(HoldersCredentialRepository holdersCr
Instant.now().plus(Duration.ofDays(5))
);
HoldersCredential holdersCredential = mockHolderCredential(verifiableCredential);
//getRepository().findAll(specification, pageRequest);
when(holdersCredentialRepository.findAll(any(Specification.class), any(PageRequest.class))).thenReturn(
new PageImpl<>(List.of(holdersCredential))
);
Expand All @@ -224,7 +223,6 @@ public static void makeFilterWorkForIssuer(IssuersCredentialRepository holdersCr
Instant.now().plus(Duration.ofDays(5))
);
IssuersCredential holdersCredential = mockIssuerCredential(verifiableCredential);
//getRepository().findAll(specification, pageRequest);
when(holdersCredentialRepository.findAll(any(Specification.class), any(PageRequest.class))).thenReturn(
new PageImpl<>(List.of(holdersCredential))
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ void issueFrameWorkVCTest201(IssueFrameworkCredentialRequest request) throws Jso

String type = request.getType();

createAndValidateVC(bpn, did, type);
createAndValidateVC(bpn, type);
//check in issuer tables
List<IssuersCredential> issuerVCs = issuersCredentialRepository.getByIssuerDidAndHolderDidAndType(miwSettings.authorityWalletDid(), did, MIWVerifiableCredentialType.USE_CASE_FRAMEWORK_CONDITION);
Assertions.assertEquals(1, issuerVCs.size());
Expand Down Expand Up @@ -195,7 +195,7 @@ void issueFrameworkCredentialTest400() throws JsonProcessingException, JSONExcep

}

private void createAndValidateVC(String bpn, String did, String type) throws JsonProcessingException, JSONException {
private void createAndValidateVC(String bpn, String type) throws JsonProcessingException, JSONException {
//create wallet
String baseBpn = miwSettings.authorityWalletBpn();
String defaultLocation = miwSettings.host() + COLON_SEPARATOR + bpn;
Expand Down

0 comments on commit 7d75be3

Please sign in to comment.