From 7d75be33b4b026fceb4469a48b5f1e7a490e543c Mon Sep 17 00:00:00 2001 From: Nitin Vavdiya Date: Tue, 28 May 2024 21:06:23 +0530 Subject: [PATCH] fix: sonar issues --- .../tractusx/managedidentitywallets/utils/MockUtil.java | 2 -- .../vc/FrameworkHoldersCredentialTest.java | 4 ++-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/test/java/org/eclipse/tractusx/managedidentitywallets/utils/MockUtil.java b/src/test/java/org/eclipse/tractusx/managedidentitywallets/utils/MockUtil.java index 7743c10b..5168e6b5 100644 --- a/src/test/java/org/eclipse/tractusx/managedidentitywallets/utils/MockUtil.java +++ b/src/test/java/org/eclipse/tractusx/managedidentitywallets/utils/MockUtil.java @@ -208,7 +208,6 @@ public static void makeFilterWorkForHolder(HoldersCredentialRepository holdersCr Instant.now().plus(Duration.ofDays(5)) ); HoldersCredential holdersCredential = mockHolderCredential(verifiableCredential); - //getRepository().findAll(specification, pageRequest); when(holdersCredentialRepository.findAll(any(Specification.class), any(PageRequest.class))).thenReturn( new PageImpl<>(List.of(holdersCredential)) ); @@ -224,7 +223,6 @@ public static void makeFilterWorkForIssuer(IssuersCredentialRepository holdersCr Instant.now().plus(Duration.ofDays(5)) ); IssuersCredential holdersCredential = mockIssuerCredential(verifiableCredential); - //getRepository().findAll(specification, pageRequest); when(holdersCredentialRepository.findAll(any(Specification.class), any(PageRequest.class))).thenReturn( new PageImpl<>(List.of(holdersCredential)) ); diff --git a/src/test/java/org/eclipse/tractusx/managedidentitywallets/vc/FrameworkHoldersCredentialTest.java b/src/test/java/org/eclipse/tractusx/managedidentitywallets/vc/FrameworkHoldersCredentialTest.java index 1db24128..4089d7fe 100644 --- a/src/test/java/org/eclipse/tractusx/managedidentitywallets/vc/FrameworkHoldersCredentialTest.java +++ b/src/test/java/org/eclipse/tractusx/managedidentitywallets/vc/FrameworkHoldersCredentialTest.java @@ -156,7 +156,7 @@ void issueFrameWorkVCTest201(IssueFrameworkCredentialRequest request) throws Jso String type = request.getType(); - createAndValidateVC(bpn, did, type); + createAndValidateVC(bpn, type); //check in issuer tables List issuerVCs = issuersCredentialRepository.getByIssuerDidAndHolderDidAndType(miwSettings.authorityWalletDid(), did, MIWVerifiableCredentialType.USE_CASE_FRAMEWORK_CONDITION); Assertions.assertEquals(1, issuerVCs.size()); @@ -195,7 +195,7 @@ void issueFrameworkCredentialTest400() throws JsonProcessingException, JSONExcep } - private void createAndValidateVC(String bpn, String did, String type) throws JsonProcessingException, JSONException { + private void createAndValidateVC(String bpn, String type) throws JsonProcessingException, JSONException { //create wallet String baseBpn = miwSettings.authorityWalletBpn(); String defaultLocation = miwSettings.host() + COLON_SEPARATOR + bpn;