Fix/ssi lib breaking changes #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
mknoopvw
approved these changes
Nov 30, 2023
|
🎉 This PR is included in version 0.2.0-develop.9 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This was referenced Nov 30, 2023
|
🎉 This PR is included in version 0.3.0-develop.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 0.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will fix the typo
verifiywhich was pulled from thecx-ssi-libdependency (the GH version). Since there is a Maven Central version of the current version, we have to fix it, before any other PRs can succeed.This move to the Maven Central version of the
cx-ssi-libdeprecates theGITHUB_USERNAMEandGITHUB_TOKENenvironment variables. I've removed them and their dependants from all files I could find.Please review this carefully.
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: