Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(validation): credential signer must be equal issuer #185

Closed
wants to merge 1 commit into from
Closed

fix(validation): credential signer must be equal issuer #185

wants to merge 1 commit into from

Conversation

DominikPinsel
Copy link
Contributor

@DominikPinsel DominikPinsel commented Dec 6, 2023 •
edited
Loading

This PR is set to main, to create a fixed v0.2.1 Release.
For the develop branch I opened #186. The develop PR remains in draft state until this is merged.

  • Set SSI library version to 0.0.18-SNAPSHOT.
    • This library has a fix that asserts, that the verifiable credential signer must also be the issuer.
  • Add Unit Test to verify fix

Dominik Pinsel dominik.pinsel@mercedes-benz.com, Mercedes-Benz Tech Innovation GmbH, legal info/Impressum

@DominikPinsel DominikPinsel mentioned this pull request Dec 6, 2023
Merged
@DominikPinsel
fix(validation): credential signer must be equal issuer
8878207 
Signed-off-by: Dominik Pinsel <dominik.pinsel@mercedes-benz.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@borisrizov-zf
Copy link
Contributor

@DominikPinsel I've released the 0.0.18 version of the cx-ssi-lib. It already tests this, but I guess a MIW test is also beneficial.

@DominikPinsel
Copy link
Contributor Author

Closed :) We will merge this to develop only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florianrusch-zf florianrusch-zf Awaiting requested review from florianrusch-zf

@borisrizov-zf borisrizov-zf Awaiting requested review from borisrizov-zf

Assignees

@DominikPinsel DominikPinsel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DominikPinsel @borisrizov-zf