Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add test to check verifiable credential issuer equals signer #186

Merged
merged 1 commit into from
Jan 17, 2024
Merged

chore: add test to check verifiable credential issuer equals signer #186

merged 1 commit into from
Jan 17, 2024

Conversation

DominikPinsel
Copy link
Contributor

@DominikPinsel DominikPinsel commented Dec 6, 2023

This PR is set to develop.
For the main branch I opened #185. The develop PR remains in draft state until this is merged.

-- NOT RELEVANT

  • Set SSI library version to 0.0.18-SNAPSHOT.
    • This library has a fix that asserts, that the verifiable credential signer must also be the issuer.

-- NOT RELEVANT (borisrizov-zf)

  • Add Unit Test to verify fix

Dominik Pinsel dominik.pinsel@mercedes-benz.com, Mercedes-Benz Tech Innovation GmbH, legal info/Impressum

Copy link

sonarcloud bot commented Dec 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@borisrizov-zf
Copy link
Contributor

@DominikPinsel please rebase, and remove all files from the commit, but the VerifiableCredentialIssuerEqualProofSignerTest.java.

If you don't want to merge this, please close the PR.

@DominikPinsel
Copy link
Contributor Author

@DominikPinsel please rebase, and remove all files from the commit, but the VerifiableCredentialIssuerEqualProofSignerTest.java.

If you don't want to merge this, please close the PR.

Sure :) Also removed draft state

@DominikPinsel DominikPinsel marked this pull request as ready for review January 10, 2024 15:18
@DominikPinsel DominikPinsel changed the title Fix/credential issuer must be equal signer chore: add test to check verifiable credential issuer equals signer Jan 10, 2024
@borisrizov-zf
Copy link
Contributor

@DominikPinsel please rebase, so we can merge this. Thanks!

Copy link
Contributor

@borisrizov-zf borisrizov-zf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait for rebase and merge.

Signed-off-by: Dominik Pinsel <dominik.pinsel@mercedes-benz.com>
@DominikPinsel
Copy link
Contributor Author

Wait for rebase and merge.

@borisrizov-zf rebased :)

Copy link

sonarcloud bot commented Jan 17, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@borisrizov-zf borisrizov-zf merged commit fb6912e into eclipse-tractusx:develop Jan 17, 2024
7 checks passed
Copy link

🎉 This PR is included in version 0.4.0-develop.12 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Copy link

github-actions bot commented Feb 9, 2024

🎉 This PR is included in version 0.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants