Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: TRG 7.00 - update copyright header #234

Conversation

borisrizov-zf
Copy link
Contributor

@borisrizov-zf borisrizov-zf commented Jan 10, 2024

Description

Comply with TRG 7.00 and update all copyright headers to point to current year.

Command used:

find . -type f -exec sed -i -E 's/(.*)Copyright \(c\) 2021,2023 Contributors to the Eclipse Foundation/\1Copyright \(c\) 2021,2024 Contributors to the Eclipse Foundation/g' {} \;

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

Copy link

sonarcloud bot commented Jan 10, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@carslen carslen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kudos for attempting to meet TRGs, but do not update the Copyright header just because of the year change. The year (range) in the copyright header should be changed in case of changes to the file.
The Eclipse Handbook recommendation: "The year is expressed as a single year or a range spanning the year of the very initial assertion and that of the most recent change."

Depending on the IDE you're using, some IDE's have great features to support you to keep your copyright header up to date (e.g. JetBrains Copyright feature available for most Jetbrains IDEs). Other IDEs or Editors like VS Code may provide similar features/Plugins/Extensions (e.g. VS Code Extensions).

Please do not merge this PR, but update the copyright header when code is changed/extended.

@borisrizov-zf
Copy link
Contributor Author

@carslen Ok, no problem, but we should maybe update the TRG text as it led me to believe that this is necessary.

@carslen
Copy link
Contributor

carslen commented Jan 15, 2024

Feel free to create a draft with an updated TRG. I guess you're pointing to this section of the TRG:

Keep the following updated for each pull request to the default branch (main)

  • Legal Documentation: TRG 7.01
  • License and copyright header: TRG 7.02
    • must be present in every file if possible
    • update the year in the copyright section at the beginning of each new year

From my point of view this isn't misleading. The TRG describes recurring activities you have to take care of, when creating a new PR because of changes to the code, docs, etc. As no changes have been made to the code, no update of the copyright headers is required.

@borisrizov-zf borisrizov-zf deleted the chore/update-copyright-year-2024 branch January 16, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants