-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Make self-issued tokens one-time-use only #268
Feature: Make self-issued tokens one-time-use only #268
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just add the liquibase comments and test it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll test locally and merge afterwards. Look good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doing local tests, and will merge afterwards.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a bug when re-wrapping an access token.
Quality Gate passedIssues Measures |
Fixes for re-wrapping an access token applied in e047550 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I'll do the manual tests and ping you if anything arises.
🎉 This PR is included in version 0.5.0-develop.7 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This issue has been resolved in version 0.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This is implementation of Make self-issued tokens one-time-use only
Closes: #264
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: