Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Make self-issued tokens one-time-use only #268

Conversation

aleksandra-bel
Copy link
Contributor

@aleksandra-bel aleksandra-bel commented Mar 6, 2024

This is implementation of Make self-issued tokens one-time-use only
Closes: #264

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

Copy link
Contributor

@borisrizov-zf borisrizov-zf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just add the liquibase comments and test it.

@aleksandra-bel aleksandra-bel marked this pull request as ready for review March 6, 2024 14:17
Copy link
Contributor

@borisrizov-zf borisrizov-zf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll test locally and merge afterwards. Look good!

Copy link
Contributor

@borisrizov-zf borisrizov-zf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing local tests, and will merge afterwards.

@borisrizov-zf borisrizov-zf self-requested a review March 7, 2024 13:13
Copy link
Contributor

@borisrizov-zf borisrizov-zf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a bug when re-wrapping an access token.

Copy link

sonarcloud bot commented Mar 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@andreibogus
Copy link
Contributor

Fixes for re-wrapping an access token applied in e047550

Copy link
Contributor

@borisrizov-zf borisrizov-zf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I'll do the manual tests and ping you if anything arises.

@borisrizov-zf borisrizov-zf merged commit c6edd97 into eclipse-tractusx:develop Mar 7, 2024
8 checks passed
Copy link

github-actions bot commented Mar 7, 2024

🎉 This PR is included in version 0.5.0-develop.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Copy link

github-actions bot commented Jul 5, 2024

🎉 This issue has been resolved in version 0.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants