Feature/bpn auth validation #282
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borisrizov-zf
requested changes
Apr 11, 2024
src/main/java/org/eclipse/tractusx/managedidentitywallets/constant/StringPool.java
Outdated
Show resolved
Hide resolved
borisrizov-zf
approved these changes
Apr 15, 2024
|
@andreibogus @aleksandra-bel please rebase, hopefully DAST will stop whining. |
aleksandra-bel
force-pushed
the
feature/bpn_auth_validation
branch
from
e280338
to
7074ad4
Compare
| } | ||
|
|
||
| String wwwAuthenticate = computeWWWAuthenticateHeaderValue(parameters); | ||
| response.addHeader("WWW-Authenticate", wwwAuthenticate); |
There was a problem hiding this comment.
maybe we can use constant from class org.springframework.http.HttpHeaders
borisrizov-zf
force-pushed
the
feature/bpn_auth_validation
branch
from
7074ad4
to
533feda
Compare
|
|
Closing this is PR as there has been no update from the author for a long time. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is implementation of Feature: BPN authorisation validation
Closes: #278
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: