feat: add imagePullSecrets #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evegufy
requested changes
Sep 16, 2024
There was a problem hiding this comment.
Hi @mgarciaLKS thank you for your contribution! Could you please enable the imagePullSecrets also for the migrations job?:
- https://github.com/eclipse-tractusx/policy-hub/blob/v1.1.0/charts/policy-hub/values.yaml#L49
- https://github.com/eclipse-tractusx/policy-hub/blob/v1.1.0/charts/policy-hub/templates/job-policy-hub-migrations.yaml
I noticed that I forgot the jobs during the review of the portal PR eclipse-tractusx/portal#396:
- https://github.com/eclipse-tractusx/portal/blob/portal-2.2.0/charts/portal/templates/cronjob-backend-processes.yaml
- https://github.com/eclipse-tractusx/portal/blob/portal-2.2.0/charts/portal/templates/cronjob-backend-portal-maintenance.yaml
- https://github.com/eclipse-tractusx/portal/blob/portal-2.2.0/charts/portal/templates/job-backend-provisioning-migrations.yaml
- https://github.com/eclipse-tractusx/portal/blob/portal-2.2.0/charts/portal/templates/job-backend-portal-migrations.yaml
Would be great if you could enable those portal jobs as well.
|
Hey @evegufy, hope the vacations went well. |
evegufy
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The imagePullSecrets field allows you to specify secrets needed to pull Docker images from private repositories.
Request by @evegufy
Why
In many organizations, container images are stored in private registries rather than public ones for security and compliance reasons. To pull these images, Kubernetes needs credentials, which are provided via imagePullSecrets. This code dynamically includes the necessary secrets for pulling images, based on the configuration provided in the Helm chart's values file.
Checklist