cleanup scripts

.github/workflows/pre-checks.yml

@@ -1,5 +1,5 @@
 ###############################################################
-# Copyright (c) 2021, 2023 Contributors to the Eclipse Foundation
+# Copyright (c) 2021, 2024 Contributors to the Eclipse Foundation
 #
 # See the NOTICE file(s) distributed with this work for additional
 # information regarding copyright ownership.
@@ -28,11 +28,6 @@ on:
     types: [opened, synchronize, reopened]
   workflow_dispatch:
 
-env:
-  # variables needed for scripts/check_package_versions.sh
-  BASE_NAME: "${{ github.event.pull_request.base.ref }}"
-  HEAD_NAME: "${{ github.event.pull_request.head.ref }}"
-
 jobs:
 
   changes:
@@ -88,12 +83,13 @@ jobs:
       - name: Check Package Versions
         shell: bash
         run: |
-          script_output=$(./scripts/check_package_versions.sh)
+          script_output=$(./scripts/nuget_version_check.sh origin/${{ github.event.pull_request.base.ref }})
 
           if [ -z "$script_output" ]; then
             echo "Expected version updates were made"
           else
-            echo "the following packages need a version update: $script_output"
+            echo "the following packages need a version update:"
+            echo "$script_output"
             echo "Please see https://github.com/eclipse-tractusx/portal-backend/blob/main/src/framework/README.md for further information"
             exit 1
           fi

scripts/nuget_version_check.sh

@@ -21,7 +21,7 @@
 
 # Get branch names
 if [ "$#" -ne 1 ]; then
-  echo "Usage: $0 <branchRange>"
+  echo "Usage: $0 <baseBranch|branchRange>"
   exit 1
 fi
 
@@ -30,18 +30,19 @@ branchRange="$1"
 
 # Initialize a global arrays to store data
 version_update_needed=()
-first_version=""
-unmatching_package=()
 
 check_version_update(){
   local project="$1"
   local props_file=$project"Directory.Build.props"
 
+  # check if the code (.cs) unchanged
   if ! git diff --name-only $branchRange -- "$project" | grep -qE '\.cs$' ||
+    # check if build.props file has been deleted
     ! [ -z $(git diff --name-only --diff-filter=D $branchRange -- "$props_file") ]; then
     return
   fi
 
+  # check if build.props file is unchanged
   if [ -z $(git diff --name-only $branchRange -- "$props_file") ]; then
     version_update_needed+=($project)
     return

scripts/update_framework_versions.sh

@@ -1,5 +1,5 @@
 ###############################################################
-# Copyright (c) 2024Contributors to the Eclipse Foundation
+# Copyright (c) 2024 Contributors to the Eclipse Foundation
 #
 # See the NOTICE file(s) distributed with this work for additional
 # information regarding copyright ownership.