Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Management | Email Notification | Not getting Email on the Rejection of App Release Request #1015

Closed
tfjanjua opened this issue Sep 19, 2024 · 0 comments · Fixed by #1017
Assignees
Labels
bug Something isn't working
Milestone

Comments

@tfjanjua
Copy link
Contributor

Current Behavior

In the App Request Management page, users are not receiving email notifications when an App Release Request is rejected.

Expected Behavior

An email notification should be sent to the user when the App Release Request is rejected.
https://github.com/eclipse-tractusx/portal-assets/blob/main/docs/developer/04.%20Apps/03.%20App%20Release%20Approval/04.%20Decline%20App%20Release.md

Steps To Reproduce

  1. Login to Portal using App Manager access.
  2. Submit an App Release Request.
  3. Login to Portal App using CX-Admin access.
  4. Have the request rejected by an admin.
  5. Check the email for the rejection notification.

Findings

There is a method called DeclineOfferAsync in the OfferService.cs file that calls the RoleBaseSendMail method at the end, but there is no portalRepositories.SaveAsync() method called after all the steps so, because of that records are not getting saved into the database and process worker is not able to pick any email record to process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
2 participants