fix(leadPictureId): responding image id for service offer type

[tfjanjua]

Description

Responding leadPictureId for services and updated the response of following APIs, including test cases:

• /api/services/active
• /api/services/{serviceId}

Why

Default/hard coded service images displaying on “Service Marketplace“ but actual service image should display.

Issue

Ref: 1040

Checklist

• I have followed the contributing guidelines
• I have performed a self-review of my own code
• I have successfully tested my changes locally
• I have added tests that prove my changes work
• I have checked that new and existing tests pass locally with my changes

[ntruchsess]

see comments

[Usmanfee]

@tfjanjua here is the FE draft PR FYI : eclipse-tractusx/portal-frontend#1197
upstream issue: eclipse-tractusx/portal-frontend#1195. :)

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

relevant changes are implemented

[ntruchsess]

@tfjanjua @MaximilianHauer shall we wait for the FE-PR eclipse-tractusx/portal-frontend#1197 to be also ready before merging this PR? (The LeadImageUrl that has been added to the api reponses would be silently ignored by the FE until then).

[tfjanjua]

Thanks for the review @ntruchsess
I see @MaximilianHauer has added FE-ticket (eclipse-tractusx/portal-frontend#1195) into Backlog but we need this change as part of our release because this hard coded or static image of Service offer type would be a bad user experience for our customers.

cc: @ybidois | @Usmanfee

[MaximilianHauer]

@tfjanjua backlog does not mean that you are not allowed to contribute ;) :D

what i dont understand is that you contribute two times the same issue with different PR. can you align on what we should focus on ?

eclipse-tractusx/portal-frontend#1195
#1040

[tfjanjua]

@tfjanjua backlog does not mean that you are not allowed to contribute ;) :D

what i dont understand is that you contribute two times the same issue with different PR. can you align on what we should focus on ?

eclipse-tractusx/portal-frontend#1195 #1040

Thanks for the feedback @MaximilianHauer
The links of tickets you have mentioned are two different tickets from two different repositories but for same functionality because I have added one param in response of API and frontend supposed to accommodate that new param in frontend UI.

Please let me know if you have any question.

[ntruchsess]

@tfjanjua As discussed with @MaximilianHauer I'm merging this PR as it's save to add those urls to the api-response - please discuss on how to proceed with the corresponding FE-changes in the respective tickets.

[tfjanjua]

Thanks for the merge @ntruchsess | @MaximilianHauer
PR with changes (related to leadPictureId) are also ready in FE repo: eclipse-tractusx/portal-frontend#1197