Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tablerename): company service account related tables renamed #1060

Merged
merged 2 commits into from
Oct 9, 2024
Merged

feat(tablerename): company service account related tables renamed #1060

merged 2 commits into from
Oct 9, 2024

Conversation

AnuragNagpure
Copy link
Contributor

@AnuragNagpure AnuragNagpure commented Oct 7, 2024 •
edited by ntruchsess
Loading

Description

Renaming the existing technical users related table to relevant naming convention. Renamed table are mentioned below:

  • dim_company_service_account to external_technical_users
  • company_service_accounts to technical_users
  • company_service_account_kindes to technical_user_kinds
  • company_service_account_types to technical_user_types
  • app_instance_assigned_company_service_accounts to app_instance_assigned_technical_users
  • dim_user_creation_data to external_technical_user_creation_data
  • view company_linked_service_accounts to company_linked_technical_users

Columns of tables defining relationships to given tables are also renamed.

new table audit_connector20241008 has been added to match column name adjustment

Why

For proper naming convention and understandability tables name re changed.

Issue

#879

Checklist

Please delete options that are not relevant.

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@ntruchsess ntruchsess self-assigned this Oct 7, 2024
@ntruchsess ntruchsess force-pushed the feature/879-portal-table-naming-review-for-clarity-consistency branch 2 times, most recently from 334e4f2 to 9e87170 Compare October 8, 2024 18:36
@ntruchsess ntruchsess force-pushed the feature/879-portal-table-naming-review-for-clarity-consistency branch 3 times, most recently from 5f05f30 to 786b489 Compare October 8, 2024 19:00
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 8, 2024
View reviewed changes
src/portalbackend/PortalBackend.PortalEntities/Entities/AppInstance.cs
@@ -27,7 +27,7 @@
private AppInstance()
{
AppSubscriptionDetails = new HashSet<AppSubscriptionDetail>();
ServiceAccounts = new HashSet<AppInstanceAssignedCompanyServiceAccount>();
AppInstanceAssignedTechnicalUsers = new HashSet<AppInstanceAssignedTechnicalUser>();

Check warning

Code scanning / CodeQL

Virtual call in constructor or destructor

Avoid virtual calls in a constructor or destructor.
src/portalbackend/PortalBackend.PortalEntities/Entities/OfferSubscription.cs
@@ -37,7 +37,7 @@
public OfferSubscription()
{
ConsentAssignedOfferSubscriptions = new HashSet<ConsentAssignedOfferSubscription>();
CompanyServiceAccounts = new HashSet<CompanyServiceAccount>();
Technicalusers = new HashSet<TechnicalUser>();

Check warning

Code scanning / CodeQL

Virtual call in constructor or destructor

Avoid virtual calls in a constructor or destructor.
src/portalbackend/PortalBackend.PortalEntities/Entities/TechnicalUser.cs
Version = version;
AppInstances = new HashSet<AppInstanceAssignedCompanyServiceAccount>();
AppInstanceAssignedTechnicalUsers = new HashSet<AppInstanceAssignedTechnicalUser>();

Check warning

Code scanning / CodeQL

Virtual call in constructor or destructor

Avoid virtual calls in a constructor or destructor.
src/portalbackend/PortalBackend.PortalEntities/Entities/TechnicalUserKind.cs
{
Label = null!;
CompanyServiceAccounts = new HashSet<CompanyServiceAccount>();
TechnicalUsers = new HashSet<TechnicalUser>();

Check warning

Code scanning / CodeQL

Virtual call in constructor or destructor

Avoid virtual calls in a constructor or destructor.
src/portalbackend/PortalBackend.PortalEntities/Entities/TechnicalUserType.cs
{
Label = null!;
CompanyServiceAccounts = new HashSet<CompanyServiceAccount>();
TechnicalUsers = new HashSet<TechnicalUser>();

Check warning

Code scanning / CodeQL

Virtual call in constructor or destructor

Avoid virtual calls in a constructor or destructor.
@ntruchsess ntruchsess force-pushed the feature/879-portal-table-naming-review-for-clarity-consistency branch 4 times, most recently from 11f1955 to 2e5a1b2 Compare October 8, 2024 22:12
ntruchsess
ntruchsess previously approved these changes Oct 8, 2024
View reviewed changes
@ntruchsess ntruchsess linked an issue Oct 8, 2024 that may be closed by this pull request
Asynchron Tech Users - Portal Table Naming Review for Clarity and Consistency #879
Closed
@ntruchsess ntruchsess added this to the Release 24.12 milestone Oct 8, 2024
Phil91
Phil91 previously approved these changes Oct 9, 2024
View reviewed changes
@ntruchsess ntruchsess dismissed stale reviews from Phil91 and themself via 81e125f October 9, 2024 09:15
@ntruchsess ntruchsess force-pushed the feature/879-portal-table-naming-review-for-clarity-consistency branch from 2e5a1b2 to 81e125f Compare October 9, 2024 09:15
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 9, 2024 •
edited
Loading

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ntruchsess ntruchsess requested a review from Phil91 October 9, 2024 09:56
@ntruchsess ntruchsess merged commit 7259db3 into eclipse-tractusx:main Oct 9, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntruchsess ntruchsess ntruchsess approved these changes

@Phil91 Phil91 Awaiting requested review from Phil91

Assignees

@ntruchsess ntruchsess

Labels
None yet
Projects
Portal
Status: USER READY
Milestone
Release 24.12
Development

Successfully merging this pull request may close these issues.

Asynchron Tech Users - Portal Table Naming Review for Clarity and Consistency
3 participants
@AnuragNagpure @ntruchsess @Phil91