Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mailing): make sender email configurable #439

Merged
merged 1 commit into from
Feb 7, 2024
Merged

fix(mailing): make sender email configurable #439

merged 1 commit into from
Feb 7, 2024

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Jan 25, 2024 •
edited
Loading

Description

The sender mail is now configurable for all services

Why

To give the possibility to configure the sender mail

Issue

Refs: #425

Corresponding CD PR

#157

Checklist

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@Phil91 Phil91 changed the base branch from main to release/v1.8.0-RC4 January 25, 2024 07:05
@Phil91 Phil91 force-pushed the bugfix/425-configurable-sender-mail branch from 6f56dfb to b45c6e4 Compare January 25, 2024 07:15
@Phil91 Phil91 marked this pull request as ready for review January 25, 2024 07:18
@Phil91 Phil91 requested review from evegufy and ntruchsess and removed request for evegufy January 25, 2024 07:18
@Phil91 Phil91 changed the base branch from release/v1.8.0-RC4 to release/v1.8.0-RC5 January 31, 2024 13:48
@jjeroch jjeroch added this to the Version CX Release 24.03 milestone Feb 4, 2024
@ntruchsess ntruchsess force-pushed the bugfix/425-configurable-sender-mail branch from b45c6e4 to 780b7ac Compare February 7, 2024 08:14
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ntruchsess ntruchsess merged commit 0ac3b96 into release/v1.8.0-RC5 Feb 7, 2024
8 checks passed
@ntruchsess ntruchsess deleted the bugfix/425-configurable-sender-mail branch February 7, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntruchsess ntruchsess ntruchsess approved these changes

@evegufy evegufy Awaiting requested review from evegufy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 1.8.0 (24.03)
Development

Successfully merging this pull request may close these issues.
3 participants
@Phil91 @ntruchsess @jjeroch