-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(invite): create application and company on invite #960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Phil91
requested review from
ntruchsess and
evegufy
and removed request for
ntruchsess
August 29, 2024 11:32
tests/processes/Invitation.Executor.Tests/InvitationProcessServiceTests.cs
Fixed
Show fixed
Hide fixed
tests/processes/Invitation.Executor.Tests/InvitationProcessServiceTests.cs
Fixed
Show fixed
Hide fixed
Phil91
force-pushed
the
feature/700-invite
branch
from
August 29, 2024 11:53
adefd97
to
3b444b2
Compare
Phil91
force-pushed
the
feature/700-invite
branch
from
September 13, 2024 08:53
784866b
to
b924b16
Compare
ntruchsess
requested changes
Sep 17, 2024
src/administration/Administration.Service/BusinessLogic/InvitationBusinessLogic.cs
Outdated
Show resolved
Hide resolved
src/portalbackend/PortalBackend.DBAccess/Repositories/CompanyInvitationRepository.cs
Outdated
Show resolved
Hide resolved
ntruchsess
requested changes
Sep 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments
Phil91
force-pushed
the
feature/700-invite
branch
from
September 17, 2024 11:00
635b9a0
to
e879674
Compare
ntruchsess
previously approved these changes
Sep 17, 2024
Quality Gate passedIssues Measures |
ntruchsess
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
moved the creation of the company and company application to the invite business logic to directly create them with the invite.
Why
to remove the delay of the company application after invite
Issue
Refs: #700
Checklist