chore: move regex to pattern with test cases

eclipse-tractusx · Oct 10, 2024 · 7b9e5d8 · 7b9e5d8
1 parent 1862311
commit 7b9e5d8
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 3 deletions.
diff --git a/src/components/pages/AppOverview/index.tsx b/src/components/pages/AppOverview/index.tsx
@@ -57,6 +57,7 @@ import { fetchImageWithToken } from 'services/ImageService'
 import { setCurrentActiveStep } from 'features/appManagement/slice'
 import { setAppId, setAppStatus } from 'features/appManagement/actions'
 import NoItems from '../NoItems'
+import { isValidAppOverviewSearch } from 'types/Patterns'
 
 export default function AppOverview() {
   const { t } = useTranslation()
@@ -222,9 +223,7 @@ export default function AppOverview() {
 
   const doSearch = useCallback(
     (expr: string) => {
-      const validateExpr =
-        /^[ A-Za-z0-9!@#$%^&*()_+\-=[\]{};':"\\|,.<>/?]*$/.test(expr)
-      if (!validateExpr) {
+      if (!isValidAppOverviewSearch(expr)) {
         return
       }
       setSearchExpr(expr)

diff --git a/src/types/Patterns.test.ts b/src/types/Patterns.test.ts
@@ -29,6 +29,7 @@ import {
   isCountryCode,
   isClientID,
   isPersonName,
+  isValidAppOverviewSearch,
 } from './Patterns'
 
 const TESTDATA = {
@@ -214,6 +215,10 @@ const TESTDATA = {
     valid: ['sa-12', 'JSSS', 'Julia12'],
     invalid: ['&^%#@', '!', 'hash &*^#$'],
   },
+  appOverview: {
+    valid: ['sa-12', '1234', 'Test123!@#'],
+    invalid: ['🚀 Rocket!', 'Invalid\nNewLine'],
+  },
 }
 
 describe('Input Pattern Tests', () => {
@@ -304,4 +309,12 @@ describe('Input Pattern Tests', () => {
       expect(isClientID(expr)).toBe(false)
     })
   })
+  it('validate appoverview search', () => {
+    TESTDATA.appOverview.valid.forEach((expr) => {
+      expect(isValidAppOverviewSearch(expr)).toBe(true)
+    })
+    TESTDATA.appOverview.invalid.forEach((expr) => {
+      expect(isValidAppOverviewSearch(expr)).toBe(false)
+    })
+  })
 })
diff --git a/src/types/Patterns.ts b/src/types/Patterns.ts
@@ -120,6 +120,9 @@ export const Patterns = {
     POSTAL_CODE:
       /^(?!.*\s$)(?=[a-zA-Z\d-]{0,10}[-\s]?[a-zA-Z\d-]{0,10}$)[a-zA-Z\d\s-]{2,10}$/,
   },
+  appOverview: {
+    SEARCH: /^[ A-Za-z0-9!@#$%^&*()_+\-=[\]{};':"\\|,.<>/?]*$/,
+  },
 }
 
 export const isEmpty = (expr: string) => !expr || expr.trim() === ''
@@ -208,5 +211,7 @@ export const isCompanyVies = (expr: string) =>
   Patterns.companyData.VIES.test(expr)
 export const isPostalCode = (expr: string) =>
   Patterns.companyData.POSTAL_CODE.test(expr)
+export const isValidAppOverviewSearch = (expr: string) =>
+  Patterns.appOverview.SEARCH.test(expr)
 
 export default Patterns