bugfix(validation): code smell fix

eclipse-tractusx · Jul 14, 2023 · 9b55c8f · 9b55c8f
1 parent 9d54d87
commit 9b55c8f
Showing 1 changed file with 21 additions and 17 deletions.
diff --git a/src/components/shared/basic/ReleaseProcess/AppPage/index.tsx b/src/components/shared/basic/ReleaseProcess/AppPage/index.tsx
@@ -404,29 +404,33 @@ export default function AppPage() {
     dispatch(decrement())
   }
 
+  const selectCheckboxPrivacyPolicies = (policy: string, select: boolean) => {
+    if (
+      selectedPrivacyPolicies &&
+      selectedPrivacyPolicies[0] === privacyPolicyNone
+    ) {
+      setSelectedPrivacyPolicies([...[], policy])
+    } else {
+      const isSelected = selectedPrivacyPolicies?.includes(policy)
+      if (isSelected && selectedPrivacyPolicies.length === 1)
+        setPrivacyError(true)
+      if (!isSelected && select) {
+        setSelectedPrivacyPolicies([...selectedPrivacyPolicies, policy])
+      } else if (isSelected && !select) {
+        const oldPrivacyPolicies = [...selectedPrivacyPolicies]
+        oldPrivacyPolicies.splice(oldPrivacyPolicies.indexOf(policy), 1)
+        setSelectedPrivacyPolicies([...oldPrivacyPolicies])
+      }
+    }
+  }
+
   const selectPrivacyPolicies = (
     policy: string,
     select: boolean,
     type: string
   ) => {
     if (type === 'checkbox') {
-      if (
-        selectedPrivacyPolicies &&
-        selectedPrivacyPolicies[0] === privacyPolicyNone
-      ) {
-        setSelectedPrivacyPolicies([...[], policy])
-      } else {
-        const isSelected = selectedPrivacyPolicies?.includes(policy)
-        if (isSelected && selectedPrivacyPolicies.length === 1)
-          setPrivacyError(true)
-        if (!isSelected && select) {
-          setSelectedPrivacyPolicies([...selectedPrivacyPolicies, policy])
-        } else if (isSelected && !select) {
-          const oldPrivacyPolicies = [...selectedPrivacyPolicies]
-          oldPrivacyPolicies.splice(oldPrivacyPolicies.indexOf(policy), 1)
-          setSelectedPrivacyPolicies([...oldPrivacyPolicies])
-        }
-      }
+      selectCheckboxPrivacyPolicies(policy, select)
     } else if (type === 'radio') {
       setSelectedPrivacyPolicies([...[], policy])
     }