Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Usertype column to technical user management list #1090

Conversation

shahmargi12
Copy link
Contributor

@shahmargi12 shahmargi12 commented Sep 9, 2024

Description

This PR introduces a new column named Usertype in the technicalUserManagement table. The column is positioned between Type (renamed to Ownership) and Offer Link.

Key Changes:

  • Added the Usertype column to display the usertype value.
  • Updated the Type column to Ownership.
  • Ensured the layout remains responsive after the addition of the Usertype column.
  • Ensured that the page gracefully handles missing or incorrect data without breaking functionality.

Dependency:
This change depends on the backend update to include the usertype field in the API response from GET: api/administration/serviceaccount/owncompany/serviceaccounts. The backend implementation for this feature is tracked under sig#789 - API Expansion for Technical User Information portal-backend#976.

⚠️ Please review and merge once the backend implementation is complete and the Usertype data is available.

Why

To enhance clarity by adding a Usertype column and renaming Type to Ownership in the technical user management list.

Issue

1082

Checklist

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally

Copy link

sonarcloud bot commented Sep 9, 2024

@MaximilianHauer MaximilianHauer added this to the Release 24.12 milestone Sep 13, 2024
Copy link
Contributor

@manojava-gk manojava-gk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lftm

@oyo oyo merged commit 531f6fb into eclipse-tractusx:main Sep 17, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: USER READY
Development

Successfully merging this pull request may close these issues.

4 participants