fix(service marketplace): list all active services

[Usmanfee]

Description

Service marketplace should have all the active services but now with implemented solution we can see all the services.

Why

Service Marketplace hasn't have the all the active services available throughout from all the service provider. Now, for each service provider marketplace we can observe all the services.

Issue

#1143

Checklist

• I have performed a self-review of my own code
• I have successfully tested my changes locally

[ss-nikunj]

lgtm

[saadanzari]

looks fine to me. lgtm

[Usmanfee]

@ma3u @oyo can you please review this PR ?
currently, I can't add you in this PR as reviewer. However, I have already created the ticket to become tractusx contributor: eclipse-tractusx/sig-infra#547 . Thank you!

[evegufy]

Hi @Usmanfee thank you for your contribution. Could you please update the DEPENDENCIES file? https://github.com/eclipse-tractusx/portal-frontend/actions/runs/10996801570?pr=1134

@oyo could you please review?

[Usmanfee]

@evegufy I have updated the dependency file but the error message still persists and no any clue with the error message.
signal need to update DEPENDENCIES.

[manojava-gk]

do not use hard coded string values

[Usmanfee]

@manojava-gk I have introduced enum for frequently used string for sorting type . can you have a look please ? :)

[manojava-gk]

@Usmanfee Just to maintain consistency use PascalCase instead. See other examples in the page.

[Usmanfee]

@manojava-gk we are also using camelcase format in e.g. PAGES and OVERLAYS enum . I am using camelcase since this is the pattern backend support.

[manojava-gk]

@Usmanfee one more thing, constants file is a place where we host most common things in the app. I do not think this sorting type is a generic one. it is very specific to the back end api. I prefer to define this in the specific api types's file.

In future we can define this in the constants when all apis sorting types are unified.

CC: @oyo

[Usmanfee]

@manojava-gk I have updated the code based on your suggestion. could you please have a look now ? Thank you :)

[manojava-gk]

Looks fine now

[oyo]

A few changes especially it's not a good pattern to handle undefined cases with an empty string. That was in the code before and went in unnoticed but now it would be a good occasion to clean that up.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[Usmanfee]

@oyo Thanks for your feedback :) . I have resolved your comments with suggested changes.