fix(app overview): enable search for numeric and special characters #1179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usmanfee
changed the title
JordanGerada3
approved these changes
Oct 7, 2024
Usmanfee
force-pushed
the
fix/app-overview-search
branch
from
007c9dd
to
1862311
Compare
JordanGerada3
approved these changes
Oct 9, 2024
evegufy
changed the title
manojava-gk
reviewed
Oct 10, 2024
|
description is a bit missleading in regards of the summary please ensure to be more precise in the future. |
|
@MaximilianHauer sorry for the confusion. I have updated the description. |
|
@Usmanfee content wise okay, please also resolve merge conflicts and update DEPENDENCIES file |
Usmanfee
force-pushed
the
fix/app-overview-search
branch
from
7b9e5d8
to
729542b
Compare
|
|
@oyo merge conflict has been resolved. please review now. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
App OverviewinApp Managementdoesn't support special characters and numeric for filteration as a parameters for search.Why
The previous regex wasn't made for to allow special and numeric characters but now with the updated regex they are now part of the allowed characters of the search.
Issue
#1177
Checklist
Please delete options that are not relevant.