sub-menu(description): implemented change description #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
oyo
requested changes
Jul 11, 2023
| longDescriptionEN: description?.[0].longDescription || '', | ||
| longDescriptionDE: description?.[1].longDescription || '', | ||
| shortDescriptionEN: description?.[0].shortDescription || '', | ||
| shortDescriptionDE: description?.[1].shortDescription || '', |
There was a problem hiding this comment.
better use ?? instead of || to assign a default value
| ) { | ||
| return `${t( | ||
| 'content.apprelease.appReleaseForm.validCharactersIncludes' | ||
| )} a-zA-Z0-9 !?@&#'"()[]_-+=<>/*.,;:% and should not start with @=<>*-+ #?%&_:;` |
There was a problem hiding this comment.
and should not start with should also be translated
| } else { | ||
| return `${t( | ||
| 'content.apprelease.appReleaseForm.validCharactersIncludes' | ||
| )} a-zA-ZÀ-ÿ0-9 !?@&#'"()[]_-+=<>/*.,;:% and should not start with @=<>*-+ #?%&_:;` |
oyo
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change Description(sub menu) functionality added for active apps
Why
To enhance.
Issue
Ref: CPLP-1558,1559
Checklist
Please delete options that are not relevant.