fix(UI): service filter in service marketplace for DE #1209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubhamv-ss
reviewed
Oct 9, 2024
oyo
requested changes
Oct 16, 2024
Usmanfee
force-pushed
the
fix/service-filter-service-marketplace
branch
from
0b42286
to
7d48785
Compare
|
|
@oyo feedback addressed . Please review now.Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In service marketplace to filter services by their types wasn't working when chosen language is DE. I fixed translations and added mapping object to get right key for the chosen language.
Why
We are passing translations to the ViewSelector component from a shared component with translations. In the case of a selected language, we always have English translations, which is not correct when matching with German translations. Therefore, we need a mechanism to map the languages.
Issue
#1208
Checklist