-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(certificates): add certification page #121
feat(certificates): add certification page #121
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some remarks
fetchCertificates: builder.query<CertificateResponse[], void>({ | ||
query: () => { | ||
return { | ||
url: 'api/administration/companydata/certificates', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can simplify from
query: () => { return { url: ... } }
to this
query: () => ({ url: ... })
)} | ||
</Box> | ||
<Typography variant="caption3" className="type"> | ||
{'Type: [ISO 9001]'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i18n?
</Typography> | ||
{ssiDetailData && ( | ||
<Typography variant="body3" className="expiryDate"> | ||
{'Valid until: '} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i18n?
)} | ||
|
||
<Typography variant="body3" className="status"> | ||
{'Status: '} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i18n?
const { t } = useTranslation() | ||
|
||
const { data } = useFetchCertificatesQuery() | ||
console.log('data', data) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove console.log
<DialogActions> | ||
<Button | ||
variant="outlined" | ||
onClick={() => dispatch(show(OVERLAYS.NONE, ''))} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better use dispatch(closeOverlay())
…hub.com/catenax-ng/tx-portal-frontend into feature/CPLP-2708/CertificateCredential
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Description
Created Certificate Page and connect it with GET API
Why
To fetch the certificate credentials
Issue
CPLP-2708
CPLP-2925
Checklist
Please delete options that are not relevant.