Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(certificates): add certification page #121

Merged

Conversation

nidhigarg-bmw
Copy link
Contributor

Description

Created Certificate Page and connect it with GET API

Why

To fetch the certificate credentials

Issue

CPLP-2708
CPLP-2925

Checklist

Please delete options that are not relevant.

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally

@nidhigarg-bmw nidhigarg-bmw requested review from manojava-gk, lavanya-bmw and oyo and removed request for manojava-gk July 11, 2023 12:45
Copy link
Contributor

@oyo oyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some remarks

fetchCertificates: builder.query<CertificateResponse[], void>({
query: () => {
return {
url: 'api/administration/companydata/certificates',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can simplify from
query: () => { return { url: ... } }
to this
query: () => ({ url: ... })

)}
</Box>
<Typography variant="caption3" className="type">
{'Type: [ISO 9001]'}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i18n?

</Typography>
{ssiDetailData && (
<Typography variant="body3" className="expiryDate">
{'Valid until: '}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i18n?

)}

<Typography variant="body3" className="status">
{'Status: '}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i18n?

const { t } = useTranslation()

const { data } = useFetchCertificatesQuery()
console.log('data', data)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove console.log

<DialogActions>
<Button
variant="outlined"
onClick={() => dispatch(show(OVERLAYS.NONE, ''))}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better use dispatch(closeOverlay())

@oyo oyo changed the title Feature/cplp 2708/certificate credential feat(certificates): add new page Jul 11, 2023
@nidhigarg-bmw nidhigarg-bmw changed the title feat(certificates): add new page feat(certificates): add certification page Jul 11, 2023
@nidhigarg-bmw nidhigarg-bmw requested a review from oyo July 11, 2023 13:14
@sonarcloud
Copy link

sonarcloud bot commented Jul 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
2.3% 2.3% Duplication

@oyo oyo merged commit 800e62e into eclipse-tractusx:dev Jul 11, 2023
3 checks passed
@oyo oyo deleted the feature/CPLP-2708/CertificateCredential branch July 11, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants