Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: retain "None" Selection for Technical Integration in Service Release #1212

Conversation

ss-nikunj
Copy link
Contributor

Description

  • Context: Service Release Process -> Step 4: Technical Integration.
  • Change: Added an if condition in useEffect to verify if the user has assigned roles. If no roles are found, the "None" option is automatically selected.

Why

  • Issue: The "None" option in the Technical Integration was not retaining its selection after submission.
  • Solution: This fix ensures that the "None" option remains selected when the user revisits the "Technical Integration" step, providing a more consistent and user-friendly experience.

Issue

Github Issue: #1161

Checklist

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas
Screen.Recording.2024-09-27.at.12.34.10.PM.mov

@ss-nikunj ss-nikunj requested review from evegufy and lavanya-bmw and removed request for evegufy October 10, 2024 05:14
@ss-nikunj ss-nikunj self-assigned this Oct 10, 2024
@ss-nikunj ss-nikunj requested review from oyo and evegufy October 10, 2024 05:14
Copy link

sonarcloud bot commented Oct 10, 2024

@ss-nikunj ss-nikunj changed the title Fix/retain none selection technical integration fix: retain "None" Selection for Technical Integration in Service Release Oct 10, 2024
@oyo oyo merged commit 408a75e into eclipse-tractusx:main Oct 16, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: USER READY
Development

Successfully merging this pull request may close these issues.

2 participants