Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix(static page): fix inline scroll height #123

Merged
merged 2 commits into from
Jul 12, 2023

Conversation

manojava-gk
Copy link
Contributor

@manojava-gk manojava-gk commented Jul 12, 2023

Description

element placed behind the stage navigation header on scroll to top. subtract the offset value with 200 to stop just before the stage header navigation

Why

not able to see the section title

Issue

NA

Checklist

Please delete options that are not relevant.

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally

@manojava-gk manojava-gk marked this pull request as ready for review July 12, 2023 06:33
@sonarcloud
Copy link

sonarcloud bot commented Jul 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@lavanya-bmw lavanya-bmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@oyo oyo merged commit 53425c2 into eclipse-tractusx:dev Jul 12, 2023
5 checks passed
@oyo oyo deleted the bugfix/inline-static-scroll branch July 12, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants