Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(usecase): add business logic to upload document #124

Conversation

nidhigarg-bmw
Copy link
Contributor

@nidhigarg-bmw nidhigarg-bmw commented Jul 12, 2023

Description

Connected usecase upload document functionality with business logic

Why

User can upload document for particular usecase if not exist.

Issue

N/A

Checklist

Please delete options that are not relevant.

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally

Copy link
Contributor

@manojava-gk manojava-gk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small finding

),
intro: t(
'content.usecaseParticipation.editUsecase.description'
).replace('{usecaseName}', credentialType),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a concept called interpolation. no need to use replace. check checklistOverlay section.
https://www.i18next.com/translation-function/interpolation

@nidhigarg-bmw nidhigarg-bmw changed the title Feature/cplp 2857/update usecase overlay logic feat(usecase): document upload business logic Jul 12, 2023
oyo
oyo previously requested changes Jul 12, 2023
Copy link
Contributor

@oyo oyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree to Mano's remark - there is a better way to replace values in i18n.

@nidhigarg-bmw nidhigarg-bmw force-pushed the feature/CPLP-2857/UpdateUsecaseOverlayLogic branch from 428ee18 to 0d89b77 Compare July 12, 2023 14:42
@sonarcloud
Copy link

sonarcloud bot commented Jul 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@manojava-gk manojava-gk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lftm

@nidhigarg-bmw nidhigarg-bmw changed the title feat(usecase): document upload business logic feat(usecase): Add Business Logic to upload document Jul 13, 2023
@evegufy evegufy changed the title feat(usecase): Add Business Logic to upload document feat(usecase): add Business Logic to upload document Jul 13, 2023
@evegufy evegufy dismissed oyo’s stale review July 13, 2023 10:13

change implemented

@evegufy evegufy merged commit 0d35b87 into eclipse-tractusx:dev Jul 13, 2023
5 checks passed
@evegufy evegufy deleted the feature/CPLP-2857/UpdateUsecaseOverlayLogic branch July 13, 2023 10:14
@evegufy evegufy changed the title feat(usecase): add Business Logic to upload document feat(usecase): add business logic to upload document Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants