-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(usecase): add business logic to upload document #124
feat(usecase): add business logic to upload document #124
Conversation
…into feature/CPLP-2857/UpdateUsecaseOverlayLogic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small finding
), | ||
intro: t( | ||
'content.usecaseParticipation.editUsecase.description' | ||
).replace('{usecaseName}', credentialType), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a concept called interpolation. no need to use replace. check checklistOverlay section.
https://www.i18next.com/translation-function/interpolation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree to Mano's remark - there is a better way to replace values in i18n.
This reverts commit 92fc79e.
428ee18
to
0d89b77
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lftm
Description
Connected usecase upload document functionality with business logic
Why
User can upload document for particular usecase if not exist.
Issue
N/A
Checklist
Please delete options that are not relevant.