Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(env): enable more readable and typo resistant injection #914

Merged
merged 11 commits into from
Oct 11, 2024
Merged

refactor(env): enable more readable and typo resistant injection #914

merged 11 commits into from
Oct 11, 2024

Conversation

oyo
Copy link
Contributor

@oyo oyo commented Jul 9, 2024 •
edited
Loading

Description

Updated implementation to inject env vars

Why

Using a more robust inject method

Issue

n/a

Checklist

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally

@oyo oyo requested a review from evegufy July 9, 2024 13:02
@oyo oyo changed the title improve(env): more readable and typo resistant env inject refactor(env): more readable and typo resistant env inject Jul 9, 2024
@sonarcloud SonarCloud

This comment was marked as outdated.

Sign in to view
@evegufy evegufy added this to the Release 24.12 milestone Aug 14, 2024
@evegufy evegufy changed the title refactor(env): more readable and typo resistant env inject refactor(env): enable more readable and typo resistant injection Oct 9, 2024
evegufy
evegufy previously approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested successfully and changelog adjusted

evegufy
evegufy previously approved these changes Oct 10, 2024
View reviewed changes
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@oyo oyo merged commit 774827d into main Oct 11, 2024
8 checks passed
@oyo oyo deleted the improve/inject-env-script branch October 11, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evegufy evegufy evegufy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Portal
Status: USER READY
Milestone
Release 24.12
Development

Successfully merging this pull request may close these issues.
2 participants
@oyo @evegufy