fix(secrets): remove unused secret #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evegufy
requested changes
Jul 23, 2024
There was a problem hiding this comment.
Hi @typecastcloud thank you! I missed that.
that one should still make it into the release for 2.1.0, could you please rebase to the release-candidate branch?
Administration and notification service still expected central-db-password as kubernetes secret. Refs: eclipse-tractusx#382
typecastcloud
force-pushed
the
fix/remove-broken-secret-config
branch
from
5a7de32
to
c066383
Compare
evegufy
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove central-db-password dependency for administration and notification service. This was missed in: #355
Why
Administration and notification service still expected central-db-password as kubernetes secret.
Issue
Refs: #382
Checklist